(#689) Fix for blemishes in 640x400 - 16 colour bitplane mode #850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lydon42
requested changes
Jan 3, 2025
src/vhdl/viciv.vhdl
Outdated
| -- @IO:C65 $D039.1-3 VIC-III:B6ADEVN @BXADEVN | ||
| -- @IO:C65 $D03A.5-7 VIC-III:B7ADODD @BXADODD | ||
| -- @IO:C65 $D03A.1-3 VIC-III:B7ADEVN @BXADEVN | ||
| -- @IO:C65 $D033.5-7 VIC-III:B0ADODD Odd rows of Even Bitplane 0 address[15:13] (only used in v400 mode) |
There was a problem hiding this comment.
You are killing the comments, can you please remove that change?
|
I feel like the change in comments came about with a desire to create clarity for the next person looking into bitplanes, and also because some of the existing comments weren't making their way into the documentation at all at present. Maybe if you could clarify what aspect of the problem you are having issue with and I can look into repairing, as I feel removing the extra clarity I was aiming for seems a shame. |
lydon42
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.