Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sanitize WPTO Hindcast parameters #144

Merged
merged 3 commits into from
Aug 14, 2024
Merged

Sanitize WPTO Hindcast parameters #144

merged 3 commits into from
Aug 14, 2024

Conversation

simmsa
Copy link
Contributor

@simmsa simmsa commented Jul 30, 2024 •
edited
Loading

Fix for #142 and #143

  • Replaces - with _ in when creating a fieldname in request_wpto
  • Adds a test to verify the above fix works properly.

@simmsa simmsa changed the base branch from master to develop July 31, 2024 14:46
@simmsa simmsa marked this pull request as ready for review July 31, 2024 14:46
@simmsa simmsa requested a review from hivanov-nrel August 1, 2024 22:03
@simmsa
Copy link
Contributor Author

simmsa commented Aug 2, 2024

@hivanov-nrel, can you take a look at this when you have time?

@simmsa simmsa merged commit f4fc083 into MHKiT-Software:develop Aug 14, 2024
68 checks passed
@rpauly18 rpauly18 mentioned this pull request Dec 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hivanov-nrel hivanov-nrel hivanov-nrel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simmsa @hivanov-nrel