Fixes bugs with the short_term_extremes_example.mlx #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MShabara when this is ready for review can you add myself and @hivanov-nrel as reviewers? If it is not ready can you convert this to a draft? Can you add a screenshot of the changes in a comment here? @hivanov-nrel, does this conflict with your work in #147? |
|
The changes done to this example are:
|
|
This should not conflict with my PR so I think it's going to be okay. I did not have issues running those example notebooks initially, but good to know you caught an edge case. From the screenshots, I would approve the changes proposed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This example case was converted from Python to MATLAB, but indexing differences between the two languages were not fully addressed. This PR fixes these issues.