Skip to content

Commit

Permalink
Dolfyn cleaning function updates (#354)
Browse files Browse the repository at this point in the history
- Rename and enhance water depth calculation and surface interference removal functions for improved robustness.
- Adjust functions to account for RDI ADCP calculations in addition to Nortek devices.
- Add errors and warnings to guide users when previous calculations are complete or data is missing.
- Remove "ignore rankwarning" to respect user preferences; update code for future package deprecations.
- Fix issues identified in Issue #353 and update tests accordingly.
- Correct determination of beam angle and carrier frequency attributes for Sentinel V ADCPs.
  • Loading branch information
jmcvey3 authored Nov 27, 2024
1 parent 27114e7 commit 79f69ca
Show file tree
Hide file tree
Showing 22 changed files with 1,876 additions and 1,435 deletions.
237 changes: 121 additions & 116 deletions examples/adcp_example.ipynb

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion examples/data/dolfyn/test_data/AWAC_test01.dolfyn.log
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
root - INFO - Position: 2, codes: (165, 5)
root - INFO - Reading hardware configuration (0x05) ping #0 @ 2...
root - INFO - Position: 50, codes: (165, 4)
root - INFO - Reading head configuration (0x04) ping #0 @ 50...
root - INFO - Reading header configuration (0x04) ping #0 @ 50...
root - INFO - Position: 274, codes: (165, 0)
root - INFO - Reading user configuration (0x00) ping #0 @ 274...
root - INFO - Position: 786, codes: (165, 32)
Expand Down
Binary file modified examples/data/dolfyn/test_data/AWAC_test01_clean.nc
Binary file not shown.
Binary file not shown.
Binary file modified examples/data/dolfyn/test_data/Sig1000_tidal_clean.nc
Binary file not shown.
Binary file modified examples/data/dolfyn/test_data/Sig500_Echo_clean.nc
Binary file not shown.
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
root - INFO - Position: 2, codes: (165, 5)
root - INFO - Reading hardware configuration (0x05) ping #0 @ 2...
root - INFO - Position: 50, codes: (165, 4)
root - INFO - Reading head configuration (0x04) ping #0 @ 50...
root - INFO - Reading header configuration (0x04) ping #0 @ 50...
root - INFO - Position: 274, codes: (165, 0)
root - INFO - Reading user configuration (0x00) ping #0 @ 274...
root - INFO - Position: 786, codes: (165, 18)
Expand Down
Binary file modified examples/data/dolfyn/test_data/vmdas02_os.nc
Binary file not shown.
Binary file modified examples/data/dolfyn/test_data/winriver02_transect.nc
Binary file not shown.
Loading

0 comments on commit 79f69ca

Please sign in to comment.