Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heat exchanging: radiator, icing & better optimization #105

Open
wants to merge 20 commits into
base: main
Choose a base branch
from

Conversation

ngomezve
Copy link
Contributor

This PR introduces models of radiators to reject residual heat, which would be required by electric systems with batteries or fuel cells. It reuses the existing heat exchanger models and adds new functions for the design and analysis of radiators.

In addition, the following changes are made:

  • The heat exchanger optimization now uses the COBYLA algorithm instead of Nelder-Mead with penalty functions.
  • The minimum heat exchanger temperature at every design point is stored to check for icing.

@ngomezve ngomezve changed the title Heat exchanging: radiator & better optimization Heat exchanging: radiator, icing & better optimization Nov 14, 2024
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 96.44970% with 6 lines in your changes missing coverage. Please review.

Project coverage is 73.62%. Comparing base (430cfd8) to head (b8dcf1f).
Report is 46 commits behind head on main.

Files with missing lines Patch % Lines
src/engine/hxfun.jl 96.44% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #105      +/-   ##
==========================================
+ Coverage   73.41%   73.62%   +0.21%     
==========================================
  Files          77       80       +3     
  Lines       13908    13598     -310     
==========================================
- Hits        10211    10012     -199     
+ Misses       3697     3586     -111     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ngomezve ngomezve marked this pull request as ready for review November 18, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant