Electric Machines #84
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #84 +/- ##
==========================================
- Coverage 73.41% 72.22% -1.20%
==========================================
Files 77 83 +6
Lines 13908 13637 -271
==========================================
- Hits 10211 9849 -362
- Misses 3697 3788 +91 ☔ View full report in Codecov by Sentry. |
ngomezve
reviewed
Oct 3, 2024
| shaft.Ri = (shaft.Ro^4 - torque / shaft.material.τmax * 2 * shaft.Ro / π)^0.25 | ||
| else | ||
| # shaft can be solid as well | ||
| shaft.Ri = 0.0 |
There was a problem hiding this comment.
I think that this case should return an error. The case when Ri = 0 is covered by the previous case as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft PR
Adds Permanent magnet electric machines, cables and inverters to be used in alternate propulsion systems.
To do:
[ ] Clean up commit history with more useful comments
[ ] Highlight areas for improvement (slot modeling for PMSM/ Carter's coeff etc)
[ ] Documentation for all new components
[ ] Tests