Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generating LTO and BADA style PTF files #87

Open
wants to merge 19 commits into
base: main
Choose a base branch
from

Conversation

aditeyashukla
Copy link
Contributor

Note: Since we are using the P3T3 method for getting NOx values, it actually just makes sense for a CFM56-7B (since the equation is matched to that)

ALSO: Added aircraft type in model files

Copy link

codecov bot commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 1.88324% with 521 lines in your changes missing coverage. Please review.

Project coverage is 71.88%. Comparing base (430cfd8) to head (fcd44b3).
Report is 24 commits behind head on main.

Files with missing lines Patch % Lines
src/mission/odperformance.jl 0.00% 344 Missing ⚠️
src/mission/LTO.jl 0.00% 64 Missing ⚠️
src/mission/printBADA.jl 0.00% 59 Missing ⚠️
src/sizing/wsize.jl 7.69% 48 Missing ⚠️
src/misc/aircraft.jl 0.00% 3 Missing ⚠️
src/mission/woper.jl 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #87      +/-   ##
==========================================
- Coverage   73.41%   71.88%   -1.54%     
==========================================
  Files          77       80       +3     
  Lines       13908    13699     -209     
==========================================
- Hits        10211     9847     -364     
- Misses       3697     3852     +155     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@askprash
Copy link
Member

@aditeyashukla can we add some tests for the functions here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants