-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compressor Map Table Interpolation v1 #92
base: main
Are you sure you want to change the base?
Conversation
…SOPT.jl into dev-compressor-functional
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #92 +/- ##
==========================================
- Coverage 73.41% 72.19% -1.22%
==========================================
Files 77 82 +5
Lines 13908 13697 -211
==========================================
- Hits 10211 9889 -322
- Misses 3697 3808 +111 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
@WyattGiroux This looks promising! Are you planning to implement the new compressor maps into |
…SOPT.jl into dev-compressor-functional
@ngomezve, I am planning on integrating them with oper and size, but need to make some unit tests for the new functions before that. In general, I've now swapped over to the NaturalNeighbours.jl library to do direct interpolation in julia. Now instead of using the bilinear functions I made, the TblMap functions are now calling interpolator functions from this package. The timing is slower (80 microseconds) but the maps are being very closely matched (max[RMSE] = 0.01-ish) using very few gridding sample points (~50^2). The package precompile time is around 1 minute. Unit tests to come next, but good progress is being made |
…ting bounding indices without arrays; adding docstrings soon
We're now faster than the original drela method and have hashing implemented such that the gridded map files only have to generate for 30 minutes once. Derivatives are a bit noisy; will try various samplings and gridding fineness later tonight. If all goes well, I'll add docstrings, unit tests, and TASOPT implementation tonight. (Original drela version on top; new table interpolation version on bottom) |
Added the
NcTblMap
andecTblMap
functions for table interpolation of speed and efficiency (+ derivatives). Also added thebilinearBounded.jl
file to perform the bilinear interpolation and thetftbl.jl
file to generate the const map data structs.Ran unit tests in test/runtests.jl and got all either passing or broken: