Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed thrust calculation when engine is choked #96

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ngomezve
Copy link
Contributor

This PR addresses issue #95, in which the thrust calculation is incorrect if the engine is choked. The code currently assumes that the far wake is isentropically expanded to atmospheric pressure, which would require a variable area convergent-divergent nozzle. Most aircraft turbofans have convergent nozzles only, so the thrust calculation is slightly different when there is choking (back pressure needs to be accounted for).

The PR fixes the thrust calculation while keeping all outputs and station notations. For the default sized case, the thrust can change by up to 1.3% after making these changes. Stations 6 and 8 were only used to calculate the thrust and could be eliminated after this PR.

fixed issue with crossed derivatives
Copy link

codecov bot commented Oct 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 42 lines in your changes missing coverage. Please review.

Project coverage is 4.80%. Comparing base (430cfd8) to head (0e10f38).
Report is 28 commits behind head on main.

Files with missing lines Patch % Lines
src/engine/tfoper.jl 0.00% 29 Missing ⚠️
src/engine/tfsize.jl 0.00% 13 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (430cfd8) and HEAD (0e10f38). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (430cfd8) HEAD (0e10f38)
3 1
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #96       +/-   ##
==========================================
- Coverage   73.41%   4.80%   -68.62%     
==========================================
  Files          77      76        -1     
  Lines       13908   13447      -461     
==========================================
- Hits        10211     646     -9565     
- Misses       3697   12801     +9104     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant