Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

max payload tweak + follow-ups #97

Merged
merged 2 commits into from
Nov 8, 2024
Merged

Conversation

argonaut22
Copy link
Collaborator

Edit in the read_input checks to include off-design missions in the max_payload exit_limit checks

context: discussed with @speth and thought about this framing vs. a max_payload in tons. decided against it since this is equivalent, though all of this needs documenting

@argonaut22
Copy link
Collaborator Author

@ngomezve, can you pls document the cabin sizing assumptions/process within the "Mission and Sizing" subsection?

  • Of special import is how that process relates to the mission parameters (e.g., answering "how do I use this if I'm designing something with variable length? variable radius? variable pax?").
  • Also, some record of where the exit_limits come from would be ideal
  • Lastly, a clear answer would be good on how this framework would handle a configuration with non-passenger "belly" cargo*. I think it should be a simple conversion of tonnage to the max payload while keeping the exit limit in the proper place, but please confirm that there aren't inconsistent assumptions in this interpretation

*for reference, 777-300ER has max Wpax = 154 000 lbs / 370 pax = 415 lbs/pax > 215 lbs/pax used for RJ and SA). meaning it can accommodate a fair bit of non-passenger cargo

Copy link

codecov bot commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 72.99%. Comparing base (430cfd8) to head (4549e07).
Report is 45 commits behind head on main.

Files with missing lines Patch % Lines
src/IO/read_input.jl 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #97      +/-   ##
==========================================
- Coverage   73.41%   72.99%   -0.43%     
==========================================
  Files          77       80       +3     
  Lines       13908    13493     -415     
==========================================
- Hits        10211     9849     -362     
+ Misses       3697     3644      -53     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ngomezve
Copy link
Contributor

ngomezve commented Nov 4, 2024

@argonaut22 Great suggestions! I'll get to it.

src/IO/read_input.jl Outdated Show resolved Hide resolved
@ngomezve
Copy link
Contributor

ngomezve commented Nov 6, 2024

@argonaut22 I addressed your suggestions for better docs in PR #101. Feel free to make more suggestions!

@argonaut22 argonaut22 marked this pull request as ready for review November 6, 2024 22:12
@askprash askprash merged commit 120ee00 into MIT-LAE:main Nov 8, 2024
3 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants