Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

0lag #330

Merged
merged 7 commits into from
Feb 13, 2025
Merged

0lag #330

merged 7 commits into from
Feb 13, 2025

Conversation

katinthehat
Copy link

Setting zero_lag to True doesn't create time shifted segments. However, if you ONLY want 0lag.hdf5, it also makes background.hdf5 and foreground.hdf5, but those are empty (aside from the 'parameters' key).

wbenoit26
wbenoit26 requested changes Feb 7, 2025
View reviewed changes
Copy link
Contributor

@wbenoit26 wbenoit26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good start, just needs a few changes. For now, I think it's fine that empty background and foreground files get created.

Katrine Kompanets added 2 commits February 11, 2025 21:50
@wbenoit26
Copy link
Contributor

I don't see the change we made to the calc_shifts_required function

@wbenoit26
Copy link
Contributor

Great, this looks like it should work. Have you tested to make sure you get the expected outputs?

@wbenoit26 wbenoit26 merged commit c131cb0 into ML4GW:main Feb 13, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wbenoit26 wbenoit26 wbenoit26 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@katinthehat @wbenoit26