Optimize scrolling text by trimming on both sides #584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were already doing this to the left, but it's useful if we also do it on the right both to minimize what we're trying to draw but also to allow different scrolling texts to appear on the same horizontal line as each other.
After this PR, a scrolling text element only needs one character's width of empty space on either side of it. Here's a modified version of the homepage where I made these 'dead' zones visible:
Compare this to the current behavior:
I think this makes something like #547 much easier in the different possible layout options because it matters much less what order things will be drawn