Closes Taskana#2563 - work in progress: debounceTime of type-ahead-co…

…mponent
MM1277 · May 28, 2024 · 93ba763 · 93ba763
1 parent 6fd112f
commit 93ba763
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 24 deletions.
diff --git a/web/src/app/shared/components/type-ahead/type-ahead.component.spec.ts b/web/src/app/shared/components/type-ahead/type-ahead.component.spec.ts
@@ -25,7 +25,7 @@ describe('TypeAheadComponent with AccessId input', () => {
   let httpTestingController: HttpTestingController;
 
   beforeEach(waitForAsync(() => {
-    TestBed.configureTestingModule({
+    await TestBed.configureTestingModule({
       imports: [
         NgxsModule.forRoot([]),
         MatFormFieldModule,

diff --git a/web/src/app/shared/components/type-ahead/type-ahead.component.ts b/web/src/app/shared/components/type-ahead/type-ahead.component.ts
@@ -40,16 +40,7 @@ export class TypeAheadComponent implements OnInit, OnDestroy {
   });
   emptyAccessId: AccessId = { accessId: '', name: '' };
 
-  constructor(private accessIdService: AccessIdsService, private httpClient: HttpClient) {
-    this.httpClient
-      .get<Customisation>(customisationUrl)
-      .pipe(take(1))
-      .subscribe((customisation) => {
-        Object.keys(customisation).forEach((lang) => {
-          this.time = customisation[lang].workbaskets.time.debounceTime;
-        });
-      });
-  }
+  constructor(private accessIdService: AccessIdsService, private httpClient: HttpClient) {}
 
   ngOnChanges(changes: SimpleChanges) {
     // currently needed because when saving, workbasket-details components sends old workbasket which reverts changes in this component
@@ -59,6 +50,16 @@ export class TypeAheadComponent implements OnInit, OnDestroy {
   }
 
   ngOnInit() {
+    this.httpClient
+      .get<Customisation>(customisationUrl)
+      .pipe(take(1))
+      .subscribe((customisation) => {
+        Object.keys(customisation).forEach((lang) => {
+          this.time = customisation[lang].workbaskets.time.debounceTime;
+          this.accessIdValueChanges();
+        });
+      });
+
     if (this.isDisabled) {
       this.accessIdForm.controls['accessId'].disable();
     }
@@ -69,19 +70,6 @@ export class TypeAheadComponent implements OnInit, OnDestroy {
         this.accessIdForm.controls['accessId'].setValue(this.lastSavedAccessId);
       }
     });
-
-    this.accessIdForm.controls['accessId'].valueChanges
-      .pipe(debounceTime(this.time), distinctUntilChanged(), takeUntil(this.destroy$))
-      .subscribe(() => {
-        const value = this.accessIdForm.controls['accessId'].value;
-        if (value === '') {
-          this.handleEmptyAccessId();
-          return;
-        }
-        this.searchForAccessId(value);
-      });
-
-    this.setAccessIdFromInput();
   }
 
   accessIdValueChanges() {