Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide Secure Folder tab on Samsung phones #1279

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

leekleak
Copy link
Contributor

@leekleak leekleak commented Feb 24, 2025

The app picks up secure folder as a work profile but afaik samsung requires users to use their "special" Secure Folder launcher and doesn't expose the contained apps to the main launcher. This leaves an empty "work" tab which may be confusing to some.

Also it seems to be generally quite bug prone as I found out that if you have one more work profile, that second profile's apps will also populate the empty Secure Folder tab despite that making absolutely no sense.

Fixes #1282

@MM2-0
Copy link
Owner

MM2-0 commented Feb 25, 2025

I think it would be better to implement this in the ProfileManager class, not at UI level.

Where did you get the 150 serial number? Is it guaranteed to always be 150?

@leekleak
Copy link
Contributor Author

I think it would be better to implement this in the ProfileManager class, not at UI level.

Makes sense

Where did you get the 150 serial number? Is it guaranteed to always be 150?

I did not find any official Samsung documentation on this, however from what I've seen on reddit, stackoverflow and issues on other github repos it seems that that serial number is indeed reserved for secure folder.

My phone matches others' experience as well for what it's worth, and while I can not guarantee that it is the same for everyone, it sure seems to be the case.

@leekleak
Copy link
Contributor Author

I think it would be better to implement this in the ProfileManager class, not at UI level.

Never mind. I'm confused now. Did i not implement this in the ProfileManager class?

@MM2-0
Copy link
Owner

MM2-0 commented Feb 25, 2025

I think it would be better to implement this in the ProfileManager class, not at UI level.

Never mind. I'm confused now. Did i not implement this in the ProfileManager class?

Yeah, you did, sorry, my bad. Apparently I'm brain dead.

@leekleak
Copy link
Contributor Author

That's fine, happens to the best of us ;)

I also just pushed a commit to fix a separate issue where in the case of multiple work accounts existing, their apps would also be merged and shown in both of their tabs. I did not test this much though, so help with that is appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate work profiles
2 participants