Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure compatibility with mocap_interfaces and mocap REP Standards #34

Merged
merged 18 commits into from
Nov 8, 2024

Conversation

aaggj
Copy link

@aaggj aaggj commented Oct 10, 2024

Ensure compatibility with mocap_interfaces and mocap REP Standards

PR Description

This PR introduces the following changes to ensure full compliance with the mocap_interfaces package and the mocap REP specifications:

  • Server address update: The server address has been updated to ensure proper connectivity.
  • Compliance with mocap_interfaces and mocap REP: All files have been modified to align with the requirements outlined in the mocap REP. This includes updates to the OptiTrack driver for compatibility.
  • Modification of package.xml: The package.xml file has been updated to reflect the necessary changes in dependencies and configuration.

These changes enhance the package’s compatibility and adherence to the latest standards in motion capture systems within ROS 2.

@fmrico fmrico changed the base branch from rolling to rep-mocap October 14, 2024 07:37
@fmrico
Copy link
Member

fmrico commented Nov 1, 2024

Hi @aaggj

Why is this failing?

@aaggj
Copy link
Author

aaggj commented Nov 3, 2024

Hi @fmrico, it is failing because it does not find the mocap interfaces package, I am trying to fix it

@aaggj
Copy link
Author

aaggj commented Nov 5, 2024

It worked in my fork, so it should work

@fmrico
Copy link
Member

fmrico commented Nov 8, 2024

Use the vcs-repo-file-url: ${GITHUB_WORKSPACE}/dependency_repos.repos approach

@aaggj
Copy link
Author

aaggj commented Nov 8, 2024

Done

@Juancams
Copy link
Member

Juancams commented Nov 8, 2024

You are in rolling, and rolling is 24. The CI is running in 22

Signed-off-by: Alberto García <[email protected]>
@Juancams Juancams merged commit d99190b into MOCAP4ROS2-Project:rep-mocap Nov 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants