feat: models api #191
Merged
feat: models api #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hopefully we can ditch py3.9 and ignore those failures.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing #190. Check in a registry file
registry.txtand model mapping filemodels.tomlcovering the test models repositories:Enforcing unix line endings was necessary in both test model repositories to get pooch hash checks to pass.
Also add some tests, and update
pyproject.tomlso the registry will be included in the published package.I'm not convinced on checking the registry/mapping files in, because they're huge, but it's convenient for testing. And it is much better than duplicating the input files to achieve all this anyway. I guess we could generate the registry before testing, and at release time for distribution with the published package. But that slows down testing.