Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(netcdf): utility package input adjustments #2106

Merged
merged 6 commits into from
Dec 17, 2024

Conversation

mjreno
Copy link
Contributor

@mjreno mjreno commented Dec 16, 2024

Adjustments to utl-ncf:

  • remove chunking record, each chunk parameter type is a standalone parameter
  • LAT and LON griddata variable names changed to LATITUDE and LONGITUDE
  • OGC_WKT shortened to WKT

Other changes:

  • warning issued if relevant chunk parameters are not provided: chunk_time and chunk_face for NETCDF_MESH2D and chunk_time, chunk_x, chunk_y and chunk_z for NETCDF_STRUCTURED. The simulation and export continues without applying user supplied parameters when the warning is issued.
  • error set if NetCDF fileout extension is not .nc
  • TDIS start_date_time set to a default of 1970-01-01T00:00:00 if not user provided
  • Revert change from fix(netcdf): rerun should overwrite netcdf output file #2051. This change inadvertently changed the export data model file type from NETCDF4 to NETCDF3_CLASSIC. The change does not support advanced options related to compression and chunking.
  • Add testing for UTL-NCF options and to verify the output file type data model

Checklist of items for pull request

  • Replaced section above with description of pull request
  • Added new test or modified an existing test
  • Ran ruff on new and modified python scripts in .doc, autotests, doc, distribution, pymake, and utils subdirectories.
  • Formatted new and modified Fortran source files with fprettify
  • Updated definition files
  • Updated input and output guide
  • Removed checklist items not relevant to this pull request

For additional information see instructions for contributing and instructions for developing.

@mjreno mjreno marked this pull request as draft December 16, 2024 21:13
@mjreno mjreno marked this pull request as ready for review December 17, 2024 18:00
@mjreno mjreno merged commit 5a0f854 into MODFLOW-ORG:develop Dec 17, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants