Hydmod interp #11
Open
Hydmod interp #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…than hydrograph location) is outside the grid. Also, started implementing a new interpolation type 'H' which will work on edge cases
…w for a new style of interpolation called 'SHYD7WTAVGEDGE' that is triggered by INTYP 'H' rather than 'I'
…issing (dry or inactive or out of the model) locations. Need to refine the substitutions but testing the overall logic first
… general matches well wtih mod2smp. Note that debugging print statements remain in place
… general matches well wtih mod2smp. Note that debugging print statements remain in place
The existing version of HYDMOD only allowed interpolation if all four points were in active cells. A couple modifications were made to the HDS and DDN observation types (they were not also made for the subsidence package observation types) 1. A new interpolation type 'H' was created in addition to 'C' and 'I'. The existing types were not changed (save for an update to a confusing error message for 'I' in the previous methods) 2. Dummy values were assigned if any of the four interpolation points falls in a DRY, NHOFLO, or otherwise inactive cell (e.g. the target for a hydrograph is at the edge of the grid). 3. Rather than assigning interpolation points outside the grid, edge cells were assigned 4. Cells with IBOUND=0, or head =HNOFLOW or head=HDRY were given dummy variables based on surrounding cells following the logic of MOD2OBS/MOD2SMP in the PEST suite of tools. A folder called hydmod_test contains an iPython notebook comparing the new HYDMOD features with MOD2SMP.
…or for existing NWT model
|
@mnfienen-usgs This PR has been around so long I don't remember what it was. Should we close it or try and wrap it up? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revisions to the interpolation procedure used for HYDMOD to make it possible to use interpolation on model cells adjacent to dry or inactive cells.
Only works on head and drawdown targets, but coul dbe expanded to subsidence.
Invoked using 'H' as interpolation type rather than 'I' or 'C'