Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove executables module/class #136

Merged
merged 2 commits into from
Jan 25, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -150,8 +150,8 @@ jobs:

- name: Build modflow6 example models
if: steps.cache-examples.outputs.cache-hit != 'true'
working-directory: modflow6-examples/etc
run: python ci_build_files.py
working-directory: modflow6-examples/autotest
run: pytest -v -n auto test_scripts.py --init

- name: Run local tests
working-directory: modflow-devtools/autotest
Expand Down
31 changes: 0 additions & 31 deletions autotest/test_executables.py

This file was deleted.

1 change: 0 additions & 1 deletion docs/index.rst
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ The `modflow-devtools` package provides a set of tools for developing and testin
:maxdepth: 2
:caption: Test fixtures

md/executables.md
md/fixtures.md
md/markers.md

Expand Down
33 changes: 0 additions & 33 deletions docs/md/executables.md

This file was deleted.

2 changes: 1 addition & 1 deletion docs/md/fixtures.md
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ def test_example_scenario(tmp_path, example_scenario):
# ...
```

**Note**: example models must first be built by running the `ci_build_files.py` script in `modflow6-examples/etc` before running tests using the `example_scenario` fixture. See the [install docs](https://modflow-devtools.readthedocs.io/en/latest/md/install.html) for more info.
**Note**: example models must first be built by running `pytest -v -n auto test_scripts.py --init` in `modflow6-examples/autotest` before running tests using the `example_scenario` fixture. See the [install docs](https://modflow-devtools.readthedocs.io/en/latest/md/install.html) for more info.

### Filtering

Expand Down
6 changes: 3 additions & 3 deletions docs/md/install.md
Original file line number Diff line number Diff line change
Expand Up @@ -67,10 +67,10 @@ cd modflow6-examples/etc
pip install -r requirements.pip.txt
```

Then, still from the `etc` folder, run:
Then, from the `autotest` folder, run:

```shell
python ci_build_files.py
pytest -v -n auto test_scripts.py --init
```

This will build the examples for subsequent use by the tests.
This will build the examples for subsequent use by the tests. To save time, models will not be run — to run the models too, omit `--init`.
36 changes: 0 additions & 36 deletions modflow_devtools/executables.py

This file was deleted.

Loading