Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: drop python 3.8, support 3.13 #168

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

mwtoews
Copy link
Collaborator

@mwtoews mwtoews commented Dec 10, 2024

This PR drops Python 3.8 support, and adds 3.13 to the test matrix. Other changes:

  • Ruff's UP check automatically fixes some of the Python code for 3.9+
  • Clean-up the setup.py wrapper file
  • Some of the CI jobs have used python-version: 3.x to specify the latest stable version of Python
  • Several steps of the CI workflow use conditionals if: matrix.python != 3.8, which are removed - is this the correct change?
  • Upgrade ReadTheDocs configuration to use ubuntu-24.04 with python 3.13

Copy link
Contributor

@wpbonelli wpbonelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @mwtoews

Several steps of the CI workflow use conditionals if: matrix.python != 3.8, which are removed - is this the correct change?

I think so

@wpbonelli wpbonelli merged commit 05926fd into MODFLOW-USGS:develop Dec 10, 2024
18 checks passed
@mwtoews mwtoews deleted the drop-py38 branch December 10, 2024 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants