Skip to content

Commit

Permalink
fix: build windows parallel with ifort 2021.12 (#1853)
Browse files Browse the repository at this point in the history
The Windows parallel distribution was built with Intel Fortran Classic 2021.11.1 until now. When running PRT models, Win parallel distributions built with this version of the compiler produce a runtime error in MethodSubcellPool.f90 when the method pool's pointers to tracking methods are deallocated. This seems like a compiler bug, though we also do not properly deallocate all pointers on the method types, which could cause memory leaks if in future PRT is modified such that allocation/deallocation happens multiple times. This will be fixed in a subsequent PR.

The crash only occurs on the Windows parallel distribution because we use ifort 2021.7 to build the other Intel distributions. The reason we did not use 2021.7 to build the Win parallel dist is parallel requires the oneAPI base kit, and I've been unable to find the installer URL for that base kit. Luckily the latest ifort (2021.12.0) doesn't have the same issue, so we can simply switch the Win parallel dist to 2021.12.0.
  • Loading branch information
wpbonelli authored Jun 2, 2024
1 parent aa6ef28 commit 852e91d
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions .github/actions/setup-par-oneapi/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ runs:
shell: bash
if: steps.oneapi-cache.outputs.cache-hit != 'true'
run: |
url="https://registrationcenter-download.intel.com/akdlm/IRC_NAS/5cb30fb9-21e9-47e8-82da-a91e00191670/w_BaseKit_p_2024.0.1.45_offline.exe"
url="https://registrationcenter-download.intel.com/akdlm/IRC_NAS/7dff44ba-e3af-4448-841c-0d616c8da6e7/w_BaseKit_p_2024.1.0.595_offline.exe"
cmp="intel.oneapi.win.mkl.devel"
"$GITHUB_WORKSPACE/modflow6/.github/common/install_intel_windows.bat" $url $cmp
rm -rf $TEMP/webimage.exe
Expand All @@ -34,7 +34,7 @@ runs:
shell: bash
if: steps.oneapi-cache.outputs.cache-hit != 'true'
run: |
url="https://registrationcenter-download.intel.com/akdlm/IRC_NAS/7a6db8a1-a8b9-4043-8e8e-ca54b56c34e4/w_HPCKit_p_2024.0.1.35_offline.exe"
url="https://registrationcenter-download.intel.com/akdlm/IRC_NAS/c95a3b26-fc45-496c-833b-df08b10297b9/w_HPCKit_p_2024.1.0.561_offline.exe"
cmp="intel.oneapi.win.cpp-dpcpp-common:intel.oneapi.win.ifort-compiler:intel.oneapi.win.mpi.devel"
"$GITHUB_WORKSPACE/modflow6/.github/common/install_intel_windows.bat" $url $cmp
rm -rf $TEMP/webimage.exe
Expand Down

0 comments on commit 852e91d

Please sign in to comment.