Skip to content

Commit

Permalink
ci: add jobs to build/test with gfortran in debug mode (#1966)
Browse files Browse the repository at this point in the history
Add jobs to the gfortran test matrix in ci.yml to build and test in debug mode. The intent is to catch situations like the one fixed by #1959. To avoid too much CI burden this PR only adds macos-14 and ubuntu-22.04 jobs. This seems to add ~15min to total runtime.
  • Loading branch information
wpbonelli authored Jul 30, 2024
1 parent a09f291 commit a1af64c
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 3 deletions.
18 changes: 16 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,19 @@ jobs:
strategy:
fail-fast: false
matrix:
os: [ ubuntu-22.04, macos-12, macos-14, windows-2022 ]
include:
- os: macos-12
debug: false
- os: macos-14
debug: false
- os: macos-14
debug: true
- os: ubuntu-22.04
debug: false
- os: ubuntu-22.04
debug: true
- os: windows-2022
debug: false
defaults:
run:
shell: bash
Expand Down Expand Up @@ -253,7 +265,9 @@ jobs:
working-directory: modflow6
run: |
setupargs=""
if [[ "${{ matrix.os }}" == "macos-14" ]]; then
if [[ "${{ matrix.debug }}" == "true" ]]; then
setupargs="-Ddebug=true -Doptimization=0"
elif [[ "${{ matrix.os }}" == "macos-14" ]]; then
setupargs="-Doptimization=1"
fi
pixi run setup builddir $setupargs
Expand Down
1 change: 0 additions & 1 deletion autotest/test_prt_disv1.py
Original file line number Diff line number Diff line change
Expand Up @@ -414,7 +414,6 @@ def compare_output(name, mf6_pls, mp7_pls, mp7_eps):
if "bprp" not in name:
# pollock's method should be (nearly) identical
mf6_pls_plck = mf6_pls[mf6_pls.particlegroup == 1]
# import pdb; pdb.set_trace()
assert mf6_pls_plck.shape == mp7_pls.shape
assert np.allclose(mf6_pls_plck, mp7_pls, atol=1e-3)

Expand Down

0 comments on commit a1af64c

Please sign in to comment.