-
Notifications
You must be signed in to change notification settings - Fork 118
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(uzf): uzf not routing properly (#1082)
* uzf did not route water to water table unless there was an underlying uzf cell * Close #1075 * add test for uzf fix * update release notes for next release
- Loading branch information
1 parent
18deae7
commit a38723b
Showing
3 changed files
with
312 additions
and
10 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,298 @@ | ||
| """ | ||
| Test uzf for case where uzf is only in top cell. There was a | ||
| bug with this in the past in which case UZF would not send | ||
| water to water table unless there was a uzf in each cell. | ||
| """ | ||
|
|
||
| import os | ||
|
|
||
| import numpy as np | ||
| import pytest | ||
|
|
||
| try: | ||
| import pymake | ||
| except: | ||
| msg = "Error. Pymake package is not available.\n" | ||
| msg += "Try installing using the following command:\n" | ||
| msg += " pip install https://github.com/modflowpy/pymake/zipball/master" | ||
| raise Exception(msg) | ||
|
|
||
| try: | ||
| import flopy | ||
| except: | ||
| msg = "Error. FloPy package is not available.\n" | ||
| msg += "Try installing using the following command:\n" | ||
| msg += " pip install flopy" | ||
| raise Exception(msg) | ||
|
|
||
| from framework import testing_framework | ||
| from simulation import Simulation | ||
|
|
||
| ex = ["gwf_uzf05a"] | ||
| exdirs = [] | ||
| for s in ex: | ||
| exdirs.append(os.path.join("temp", s)) | ||
| ddir = "data" | ||
| nlay, nrow, ncol = 3, 1, 1 | ||
|
|
||
| thts = 0.30 # saturated water content | ||
| thtr = 0.05 # residual water content | ||
| thti = 0.10 # initial water content | ||
| strt = 15.0 | ||
|
|
||
|
|
||
| def build_model(idx, dir): | ||
|
|
||
| perlen = [1.0] | ||
| nper = len(perlen) | ||
| nstp = [1] | ||
| tsmult = nper * [1.0] | ||
| delr = 1.0 | ||
| delc = 1.0 | ||
| delv = 30.0 | ||
| top = 90.0 | ||
| botm = [top - (k + 1) * delv for k in range(nlay)] | ||
| laytyp = 1 | ||
| ss = 1.0e-5 | ||
| sy = 0.3 | ||
|
|
||
| # unsat props | ||
| hk = 10.0 | ||
| infiltration_rate = 10. | ||
| evapotranspiration_rate = 0.0 | ||
| evt_extinction_depth = 2.0 | ||
| brooks_corey_epsilon = 3.5 # brooks corey exponent | ||
|
|
||
| tdis_rc = [] | ||
| for id in range(nper): | ||
| tdis_rc.append((perlen[id], nstp[id], tsmult[id])) | ||
|
|
||
| name = ex[idx] | ||
|
|
||
| # build MODFLOW 6 files | ||
| ws = dir | ||
| sim = flopy.mf6.MFSimulation( | ||
| sim_name=name, version="mf6", exe_name="mf6", sim_ws=ws | ||
| ) | ||
|
|
||
| # create tdis package | ||
| tdis = flopy.mf6.ModflowTdis( | ||
| sim, time_units="DAYS", nper=nper, perioddata=tdis_rc | ||
| ) | ||
|
|
||
| # create gwf model | ||
| gwfname = name | ||
| newtonoptions = "NEWTON UNDER_RELAXATION" | ||
| gwf = flopy.mf6.ModflowGwf( | ||
| sim, | ||
| modelname=gwfname, | ||
| newtonoptions=newtonoptions, | ||
| save_flows=True, | ||
| ) | ||
|
|
||
| # create iterative model solution and register the gwf model with it | ||
| nouter, ninner = 100, 10 | ||
| hclose, rclose, relax = 1.5e-6, 1e-6, 0.97 | ||
| imsgwf = flopy.mf6.ModflowIms( | ||
| sim, | ||
| print_option="SUMMARY", | ||
| outer_dvclose=hclose, | ||
| outer_maximum=nouter, | ||
| under_relaxation="DBD", | ||
| under_relaxation_theta=0.7, | ||
| inner_maximum=ninner, | ||
| inner_dvclose=hclose, | ||
| rcloserecord=rclose, | ||
| linear_acceleration="BICGSTAB", | ||
| scaling_method="NONE", | ||
| reordering_method="NONE", | ||
| relaxation_factor=relax, | ||
| filename=f"{gwfname}.ims", | ||
| ) | ||
| sim.register_ims_package(imsgwf, [gwf.name]) | ||
|
|
||
| dis = flopy.mf6.ModflowGwfdis( | ||
| gwf, | ||
| nlay=nlay, | ||
| nrow=nrow, | ||
| ncol=ncol, | ||
| delr=delr, | ||
| delc=delc, | ||
| top=top, | ||
| botm=botm, | ||
| idomain=np.ones((nlay, nrow, ncol), dtype=int), | ||
| ) | ||
|
|
||
| # initial conditions | ||
| ic = flopy.mf6.ModflowGwfic(gwf, strt=strt) | ||
|
|
||
| # node property flow | ||
| npf = flopy.mf6.ModflowGwfnpf( | ||
| gwf, save_flows=False, icelltype=laytyp, k=hk | ||
| ) | ||
| # storage | ||
| sto = flopy.mf6.ModflowGwfsto( | ||
| gwf, | ||
| save_flows=False, | ||
| iconvert=laytyp, | ||
| ss=ss, | ||
| sy=sy, | ||
| steady_state={0: False}, | ||
| transient={0: True}, | ||
| ) | ||
|
|
||
| # ghb | ||
| ghbspdict = { | ||
| 0: [[(nlay - 1, 0, 0), 15.0, hk / (0.5 * delv)]], | ||
| } | ||
| ghb = flopy.mf6.ModflowGwfghb( | ||
| gwf, | ||
| print_input=True, | ||
| print_flows=True, | ||
| stress_period_data=ghbspdict, | ||
| save_flows=False, | ||
| ) | ||
|
|
||
| # note: for specifying uzf number, use fortran indexing! | ||
| uzf_obs = { | ||
| name | ||
| + ".uzf.obs.csv": [ | ||
| (f"wc{k + 1}", "water-content", 1, depth) | ||
| for k, depth in enumerate(np.linspace(1, 20, 15)) | ||
| ] | ||
| } | ||
|
|
||
| surfdep = 1.0e-5 | ||
| uzf_pkdat = [ | ||
| [ | ||
| 0, | ||
| (0, 0, 0), | ||
| 1, | ||
| -1, | ||
| surfdep, | ||
| hk, | ||
| thtr, | ||
| thts, | ||
| thti, | ||
| brooks_corey_epsilon, | ||
| "uzf01", | ||
| ], | ||
| ] | ||
| uzf_spd = { | ||
| 0: [ | ||
| [ | ||
| 0, | ||
| infiltration_rate, | ||
| evapotranspiration_rate, | ||
| evt_extinction_depth, | ||
| thtr, | ||
| 0.0, | ||
| 0.0, | ||
| 0.0, | ||
| ], | ||
| ] | ||
| } | ||
| uzf = flopy.mf6.ModflowGwfuzf( | ||
| gwf, | ||
| print_input=True, | ||
| print_flows=True, | ||
| save_flows=True, | ||
| boundnames=True, | ||
| simulate_et=False, | ||
| unsat_etwc=True, | ||
| simulate_gwseep=True, | ||
| ntrailwaves=15, | ||
| nwavesets=40, | ||
| nuzfcells=len(uzf_pkdat), | ||
| packagedata=uzf_pkdat, | ||
| perioddata=uzf_spd, | ||
| budget_filerecord=f"{name}.uzf.bud", | ||
| wc_filerecord=f"{name}.uzf.bin", | ||
| observations=uzf_obs, | ||
| pname="uzf-1", | ||
| filename=f"{name}1.uzf", | ||
| ) | ||
|
|
||
| # output control | ||
| oc = flopy.mf6.ModflowGwfoc( | ||
| gwf, | ||
| budget_filerecord=f"{gwfname}.bud", | ||
| head_filerecord=f"{gwfname}.hds", | ||
| headprintrecord=[("COLUMNS", 10, "WIDTH", 15, "DIGITS", 6, "GENERAL")], | ||
| saverecord=[("HEAD", "ALL"), ("BUDGET", "ALL")], | ||
| printrecord=[("HEAD", "LAST"), ("BUDGET", "ALL")], | ||
| ) | ||
|
|
||
| obs_lst = [] | ||
| obs_lst.append(["obs1", "head", (0, 0, 0)]) | ||
| obs_dict = {f"{gwfname}.obs.csv": obs_lst} | ||
| obs = flopy.mf6.ModflowUtlobs( | ||
| gwf, pname="head_obs", digits=20, continuous=obs_dict | ||
| ) | ||
|
|
||
| return sim, None | ||
|
|
||
|
|
||
| def eval_flow(sim): | ||
| print("evaluating flow...") | ||
|
|
||
| name = ex[sim.idxsim] | ||
| ws = exdirs[sim.idxsim] | ||
|
|
||
| fname = os.path.join(ws, f"{name}.uzf.bin") | ||
| wobj = flopy.utils.HeadFile(fname, text="WATER-CONTENT") | ||
| wc = wobj.get_alldata() | ||
|
|
||
| fname = os.path.join(ws, f"{name}.hds") | ||
| wobj = flopy.utils.HeadFile(fname) | ||
| head = wobj.get_alldata() | ||
|
|
||
| bpth = os.path.join(ws, name + ".uzf.bud") | ||
| bobj = flopy.utils.CellBudgetFile(bpth, precision="double") | ||
| flowtogwf = bobj.get_data(text="GWF")[0] | ||
|
|
||
| print("Checking to make sure UZF cell 1 sends water to GWF cell 1") | ||
| node, node2, q, flow_area = flowtogwf[0] | ||
| assert node == 1, "uzf node should be 1" | ||
| assert node2 == 1, "GWF node should be 1" | ||
| assert np.isclose(q, -4.), "Flow from UZF to node 1 should be -4." | ||
|
|
||
| return | ||
|
|
||
|
|
||
| # - No need to change any code below | ||
| @pytest.mark.parametrize( | ||
| "idx, dir", | ||
| list(enumerate(exdirs)), | ||
| ) | ||
| def test_mf6model(idx, dir): | ||
| # initialize testing framework | ||
| test = testing_framework() | ||
|
|
||
| # build the model | ||
| test.build_mf6_models(build_model, idx, dir) | ||
|
|
||
| # run the test model | ||
| test.run_mf6(Simulation(dir, exfunc=eval_flow, idxsim=idx)) | ||
|
|
||
|
|
||
| def main(): | ||
| # initialize testing framework | ||
| test = testing_framework() | ||
|
|
||
| # run the test model | ||
| for idx, dir in enumerate(exdirs): | ||
| test.build_mf6_models(build_model, idx, dir) | ||
| sim = Simulation(dir, exfunc=eval_flow, idxsim=idx) | ||
| test.run_mf6(sim) | ||
|
|
||
| return | ||
|
|
||
|
|
||
| if __name__ == "__main__": | ||
| # print message | ||
| print(f"standalone run of {os.path.basename(__file__)}") | ||
|
|
||
| # run main routine | ||
| main() |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters