refactor(tests): use devtools fixtures #1130
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update tests that load models from external repos to use devtools fixtures, with a bit of other refactoring. This was carved out of #1066 for a smaller changeset and more incremental refactor.
modflow-devtools
to:targets
fixture)--model
/--package
pytest CLI optionsthere is a package filtering bug in devtools, soon to be fixed in fix(get_packages): fix get_packages(), fix model filtering by package modflow-devtools#44--original-regression
flag as a pytest CLI option/fixture (configured in newconftest.py
file)DEVELOPER.md
to reflect devtools convention that external model repos live side by side withmodflow6
, or optionalREPOS_PATH
environment variable to specify a different locationbuild_exes.py
andget_exes.py
. Give both scripts anargparse
CLI with optional--path
argument to specify a different bin path (defaults to the existing location,bin
in the project root).common_regression.py
. A followup PR could replace pymake usages in the rest of the tests.