refactor(disv): improve cell area calculation #1347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
langevin-usgs
commented
Sep 9, 2023
•
langevin-usgs
commented
- improve cell area calculation
- update release notes
- add test
- rerun test after new PR with the flopy get_disv_kwargs function is accepted
- update gwf_disu test using test_framework
- rewrite gwf_disv_uzf test to use get_disv_kwargs instead of custom code
- close DISV get_area has unnecessary numerical roundoff and results in false positive error reports #1346
* improve cell area calculation * close MODFLOW-USGS#1346
langevin-usgs
force-pushed
the
fix-disv-area
branch
from
0ca18e7 to
45c3a56
Compare
jdhughes-usgs
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.