Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(fmi): reduce unneeded duplication #1350

Merged
merged 2 commits into from
Sep 18, 2023
Merged

refactor(fmi): reduce unneeded duplication #1350

merged 2 commits into from
Sep 18, 2023

Conversation

wpbonelli
Copy link
Contributor

@wpbonelli wpbonelli commented Sep 14, 2023 •
edited
Loading

Clean up some rough edges from #1332

  • deduplicate in (de)allocation routines
  • use compact docstrings in gwt fmi

Thanks to @emorway-usgs for bringing this up

@emorway-usgs emorway-usgs self-requested a review September 14, 2023 15:35
emorway-usgs
emorway-usgs approved these changes Sep 15, 2023
View reviewed changes
Copy link
Contributor

@emorway-usgs emorway-usgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up, Wes.

src/Model/ModelUtilities/FlowModelInterface.f90 Outdated Show resolved Hide resolved
@wpbonelli wpbonelli marked this pull request as ready for review September 18, 2023 14:04
@langevin-usgs langevin-usgs merged commit ed2b02b into MODFLOW-USGS:develop Sep 18, 2023
45 checks passed
@wpbonelli wpbonelli deleted the fmi branch September 18, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@langevin-usgs langevin-usgs langevin-usgs approved these changes

@emorway-usgs emorway-usgs emorway-usgs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wpbonelli @emorway-usgs @langevin-usgs