refactor(tsp): Elevate FMI to generalized transport class #1386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emorway-usgs
force-pushed
the
ci-diagnose-elv_fmi_2_gen_tsp
branch
from
8bc189f to
562bcbd
Compare
langevin-usgs
approved these changes
Oct 7, 2023
There was a problem hiding this comment.
@emorway-usgs, this looks good. There was only one thing that stuck out for me and that was mention of MST in the TSP code. I will approve and merge but this is something that may need tending.
| 'Discretization (DIS6 or DISU6) package not specified.' | ||
| call store_error(errmsg) | ||
| end if | ||
| if (inmst == 0) then |
There was a problem hiding this comment.
Should MST be included in TSP?
This was referenced Oct 11, 2023
This was referenced Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First step in generalized transport refactor: elevate FMI