Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(InputOutput): address issue appending processor id for new intel … #1393

Merged
merged 6 commits into from
Oct 17, 2023
Merged

fix(InputOutput): address issue appending processor id for new intel … #1393

merged 6 commits into from
Oct 17, 2023

Conversation

jdhughes-usgs
Copy link
Contributor

…version

  • update PARALLEL.md markdown with updated build configurations and instructions
  • add Hovenweep build script
  • update Denali build script to automatically install in the correct location
  • update HPC build instructions
  • update main meson.build to build parallel MODFLOW with MPICH on non-cray systems (workaround for meson)

@jdhughes-usgs
fix(InputOutput): address issue appending processor id for new intel …
3b6fd4c 
…version

* update PARALLEL.md markdown with updated build configurations and instructions
* add Hovenweep build script
* update Denali build script to automatically install in the correct location
* update HPC build instructions
* update main meson.build to build parallel MODFLOW with MPICH on non-cray systems (workaround for meson)
@jdhughes-usgs
Copy link
Contributor Author

@wpbonelli I have modified the denali build script to directly install in the correct location on Denali based on the version. I used some of the code in update-module.slurm.batch to define the installation location. I have not modified update-module.slurm.batch but this probably needs to be done. Let me know if there is anything I should modify. I have added you as a reviewer.

@wpbonelli
Copy link
Contributor

wpbonelli commented Oct 12, 2023 •
edited
Loading

@jdhughes-usgs I think update-module.slurm.batch needs to make configurable the modulefile to use as a template for new versions, it is hardcoded 6.4.2 right now and I guess hovenweep only has 6.5.0.dev0.

But since we now build in the module app dir already the step to copy binaries can be removed I think. This changeset works in my testing.

mjr-deltares
mjr-deltares reviewed Oct 16, 2023
View reviewed changes
meson.build Outdated
if is_cray
mpi = dependency('mpich', required : true)
mpifort = dependency(mpifort_name, required : mpi.found())
dependencies += [ mpi, mpifort ]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jdhughes-usgs, I was just wondering if and why that mpi dependency on Cray is actually needed

@jdhughes-usgs
Copy link
Contributor Author

@wpbonelli let me know if I missed any of your changes

wpbonelli
wpbonelli approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@wpbonelli wpbonelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, when merged I can update the gitlab mirror and check all is well with the deployment.

@jdhughes-usgs jdhughes-usgs merged commit 37fc0da into MODFLOW-USGS:develop Oct 17, 2023
45 checks passed
@wpbonelli wpbonelli mentioned this pull request Oct 18, 2023
Merged
@jdhughes-usgs jdhughes-usgs deleted the parallel-update branch October 18, 2023 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjr-deltares mjr-deltares mjr-deltares left review comments

@wpbonelli wpbonelli wpbonelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jdhughes-usgs @wpbonelli @mjr-deltares