Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: add simple gwfgwf exchange model with sfr mover #1418

Merged
merged 2 commits into from
Nov 1, 2023
Merged

ci: add simple gwfgwf exchange model with sfr mover #1418

merged 2 commits into from
Nov 1, 2023

Conversation

jdhughes-usgs
Copy link
Contributor

  • fix sfr gwtgwt test to add mover to exchange files

@jdhughes-usgs
ci: add simple gwfgwf exchange model with sfr mover
c2462ed 
* fix sfr gwtgwt test to add mover to exchange files
@jdhughes-usgs
* modify simulation.py to add run_simulation keyword which allows a c…
171d173 
…omparison simulation to be run but not compared
@jdhughes-usgs
Copy link
Contributor Author

@wpbonelli I found out with make_comparision=False that it does not run the comparision model. I added a run_comparision keyword to allow a comparsion model to be run and then make_comparison can be use to stop the comparison. Not sure if you can think of a better way to do this.

wpbonelli
wpbonelli approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@wpbonelli wpbonelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I can take a closer look at the test framework and see if it can be simplified after this goes in.

@mjr-deltares mjr-deltares merged commit 9705a30 into MODFLOW-USGS:develop Nov 1, 2023
15 checks passed
@jdhughes-usgs jdhughes-usgs deleted the ci-testupdate branch November 9, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjr-deltares mjr-deltares mjr-deltares approved these changes

@wpbonelli wpbonelli wpbonelli approved these changes

@langevin-usgs langevin-usgs langevin-usgs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jdhughes-usgs @langevin-usgs @wpbonelli @mjr-deltares