fix(GeomUtil): fix point_in_polygon, expand unit tests #1423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
langevin-usgs
approved these changes
Nov 3, 2023
There was a problem hiding this comment.
Hey @wpbonelli, this looks good to me. Nice to see the additional tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a few bugs in the
point_in_polygon()routine added in #1407 (off-by-n errors and premature termination). The test included in that PR was only a very basic case (unit square) and so did not catch these. Fix the issues and add test cases for other geometries:Tests are also refactored a bit for easier future expansion and nicer messages on failure