feature(discretization): add get_polyverts routine to DIS/DISV #1444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* retrieve cell vertices as a 2D coordinate array * for use by PRT
| end if | ||
|
|
||
| ! allocate vertices array | ||
| allocate (polyverts(nverts, 2)) |
There was a problem hiding this comment.
Should this be allocated and accessed as polyverts(2, nverts) to be consistent with Fortran column-major ordering? Probably doesn't matter a whole lot, but it would make sense to be consistent with the rest of the code.
There was a problem hiding this comment.
switched to column-major indexing for get_polyverts as well as for point_in_polygon and its tests
* rename wrap -> closed * specify clockwise vertex order in get_polyverts docstring * column-major indexing for point_in_polygon and get_polyverts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For PRT to check release points against cell IDs, add a
get_polyverts()routine to dis/disv to get cell vertices as a 2D array of coordinates. Not tested here since discretization types aren't trivial to setup for unit testing, but testing ongoing in PRTAlso
DiscretizationBase.f90, minor docstring fixesDisBaseType