Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(netcdf): add netcdf-fortran dependency to extended (parallel) test #1451

Closed
wants to merge 3 commits into from

Conversation

mjreno
Copy link
Contributor

@mjreno mjreno commented Nov 17, 2023

Adds simple check to confirm NetCDF license information is logged to mfsim.lst by extended executable. This check is temporary and will be replaced with netcdf integrated autotests in time.

NOTE
Micromamba based installation of netcdf-fortran yields a pkg-config file (netcdf-fortran.pc) with an erroneous libdir path that leads to link failures. A workaround in this PR has been added to fix the file. Investigation is ongoing.

UPDATE netcdf-fortran-feedstock updated to fix pkg-config libdir path.

@mjreno mjreno marked this pull request as draft November 17, 2023 16:04
@mjreno
Copy link
Contributor Author

mjreno commented Nov 17, 2023

@mjreno
Copy link
Contributor Author

mjreno commented Nov 18, 2023

@mjreno mjreno marked this pull request as ready for review November 19, 2023 21:31
working-directory: modflow6
run: |
if [ "$RUNNER_OS" == "Linux" ]; then
echo "PKG_CONFIG_PATH=/home/runner/micromamba/envs/modflow6/lib/pkgconfig:$PKG_CONFIG_PATH" >> $GITHUB_ENV
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this could be done platform-independently via CONDA_PREFIX env var or environment-path output

@mjreno mjreno added the onhold Waiting for something label Jan 10, 2024
@mjreno mjreno added this to the 6.5.0 milestone Jan 15, 2024
@mjreno mjreno removed the onhold Waiting for something label Jan 15, 2024
@mjreno mjreno marked this pull request as draft January 26, 2024 16:09
@mjreno
Copy link
Contributor Author

mjreno commented Mar 16, 2024

Netcdf tests included in #1676

@mjreno mjreno closed this Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants