Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ArrayHandlers): support 1D logical array resizing, add tests #1483

Merged
merged 2 commits into from
Dec 5, 2023
Merged

feat(ArrayHandlers): support 1D logical array resizing, add tests #1483

merged 2 commits into from
Dec 5, 2023

Conversation

wpbonelli
Copy link
Contributor

@wpbonelli wpbonelli commented Dec 5, 2023 •
edited
Loading

  • support expanding 1D logical arrays (for use by PRT)
  • expand tests to check both resizing and copying of existing elements
  • use compact docstring format, remove unneeded return statements

@wpbonelli wpbonelli marked this pull request as ready for review December 5, 2023 16:58
langevin-usgs
langevin-usgs approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@langevin-usgs langevin-usgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice, @wpbonelli

@wpbonelli wpbonelli merged commit 4185096 into MODFLOW-USGS:develop Dec 5, 2023
15 checks passed
@wpbonelli wpbonelli deleted the arrayhandlers branch December 5, 2023 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@langevin-usgs langevin-usgs langevin-usgs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wpbonelli @langevin-usgs