Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(logging): consolidate logging routines in Message.f90 #1489

Merged
merged 7 commits into from
Dec 12, 2023
Merged

refactor(logging): consolidate logging routines in Message.f90 #1489

merged 7 commits into from
Dec 12, 2023

Conversation

wpbonelli
Copy link
Contributor

@wpbonelli wpbonelli commented Dec 7, 2023 •
edited
Loading

  • move logging routines from GenericUtilitiesModule and SimModule to MessageModule
  • pull logging level checks into simulation context where necessary
  • rename MessageType -> MessagesType
  • rename MessagesType procedures
  • fix docstrings in Sim.f90 and other files
  • add minimal tests

@wpbonelli wpbonelli marked this pull request as ready for review December 7, 2023 19:58
@wpbonelli wpbonelli added code refactor Nonfunctional changes maintenance Sprucing up the code labels Dec 11, 2023
@wpbonelli wpbonelli merged commit 81cdb57 into MODFLOW-USGS:develop Dec 12, 2023
15 checks passed
@wpbonelli wpbonelli deleted the messages branch December 12, 2023 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@langevin-usgs langevin-usgs langevin-usgs approved these changes

Assignees
No one assigned
Labels
code refactor Nonfunctional changes maintenance Sprucing up the code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wpbonelli @langevin-usgs