Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(framework): drop support for *.cmp file comparisons #1520

Merged
merged 2 commits into from
Dec 22, 2023

Conversation

wpbonelli
Copy link
Contributor

@wpbonelli wpbonelli commented Dec 22, 2023

* remove testmodel comparison support for <model>/compare/*.cmp files
* fix default mf6 regression executable selection
* misc cleanup
Copy link
Contributor

@langevin-usgs langevin-usgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't remember the last time I generated a *.cmp file for comparison purposes, but I wonder if we are ready to completely remove that capability. It is possible that a new testmodel would run successfully with the develop version of mf6 but not with the released version or previous release. In that case a *.cmp file might be useful. Granted, we would probably write the new test in the autotest flopy format, so maybe I'm overthinking this. With that said, we should remove unused code if possible -- just wanted to raise the potential issue.

@wpbonelli
Copy link
Contributor Author

wpbonelli commented Dec 22, 2023

@langevin-usgs if something like a compare file is needed in the future, I think we could use pytest plugins to do snapshot testing and achieve the same thing, e.g. with https://github.com/tophat/syrupy. I am putting together a demo. Do you think that is a reasonable solution? discussed offline

@wpbonelli wpbonelli merged commit d1944a2 into MODFLOW-USGS:develop Dec 22, 2023
15 checks passed
@wpbonelli wpbonelli deleted the autotest branch December 22, 2023 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants