Added nan filtering for post processing

Fixed an issue in circleci config

.circleci/config.yml

@@ -34,6 +34,7 @@ jobs:
                             # clone the repo if it doesn't exist
                             git clone --recursive https://github.com/Habush/moses-service.git
                         else
+                            cd moses-service
                             git checkout -- .
                             git pull
                         fi

crossval/filters/base_filter.py

@@ -1,7 +1,7 @@
 __author__ = 'Abdulrahman Semrie<[email protected]>'
 
 from abc import ABCMeta, abstractmethod
-
+import math
 
 class BaseFilter(metaclass=ABCMeta):
     """
@@ -19,7 +19,7 @@ def filter_negatives(self, models):
         """
         result = []
         for model in models:
-            if any([x < 0 for x in model.scores()]):
+            if any([x < 0 or math.isnan(x) for x in model.scores()]):
                 continue
             result.append(model)
 

crossval/post_process.py

@@ -45,10 +45,10 @@ def filter_models(self, base_dir=DATASET_DIR):
         self._folds_to_models()
 
         filtered_models = []
-
         filter_cls = loader.get_overfitness_filter(self.filter_type)
 
         if filter_cls is not None:
-            filtered_models = filter_cls.cut_off(self.models, self.filter_value)
+            filtered_models = filter_cls.filter_negatives(self.models)
+            filtered_models = filter_cls.cut_off(filtered_models, self.filter_value)
 
         return list(map(lambda m: m.__dict__(), filtered_models))