Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addressed Execution issues in atmosphere/develop-openacc branch and included various code optimizations #1243

Open
wants to merge 10 commits into
base: atmosphere/develop-openacc
Choose a base branch
from
Open

Addressed Execution issues in atmosphere/develop-openacc branch and included various code optimizations #1243

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
4c36af1
Code fixes to resolve the execution error in the develop-openacc branch
Oct 22, 2024
c552ae8
Fix for AWS runs.
Oct 23, 2024
992a2b5
Allow one Dynamics rank per node.
Oct 23, 2024
9d010a2
Fixing dycore scalars bug.
Oct 28, 2024
99e24c2
Added NVTX ranges and few compiler flags.
Oct 28, 2024
34e6dde
Fix few bugs and race condition.
Oct 28, 2024
4cecd5f
acc_init before MPI_Init for better UCX NIC detection
Oct 28, 2024
508799b
Generalized OpenACC Kernel Optimizations.
Oct 29, 2024
8560c2a
dyn_tend and acoustic_step optimizations.
Oct 29, 2024
7942398
NOAH LSM Optimizations.
Oct 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,17 +123,17 @@ pgi:
"CC_SERIAL = pgcc" \
"CXX_SERIAL = pgc++" \
"FFLAGS_PROMOTION = -r8" \
"FFLAGS_OPT = -O4 -byteswapio -Mfree" \
"FFLAGS_OPT = -O4 -gopt -byteswapio -Mfree -Mnosave -Mrecursive -Mstack_arrays -DMPAS_NVTX_RANGES" \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the develop-openacc branch, could you duplicate this pgi entry and name it nvhpc? Just to align more with what current users may expect to use in their make command.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gdicker1 I understand you suggestion and I agree having it as nvhpc would be appropriate. I will push the change as soon as possible.

"CFLAGS_OPT = -O3" \
"CXXFLAGS_OPT = -O3" \
"LDFLAGS_OPT = -O3" \
"FFLAGS_DEBUG = -O0 -g -Mbounds -Mchkptr -byteswapio -Mfree -Ktrap=divz,fp,inv,ovf -traceback" \
"LDFLAGS_OPT = -O3 -lnvhpcwrapnvtx" \
"FFLAGS_DEBUG = -O0 -g -Mbounds -Mchkptr -byteswapio -Mfree -Ktrap=divz,fp,inv,ovf -traceback -Mnosave -Mrecursive -DMPAS_NVTX_RANGES" \
"CFLAGS_DEBUG = -O0 -g -traceback" \
"CXXFLAGS_DEBUG = -O0 -g -traceback" \
"LDFLAGS_DEBUG = -O0 -g -Mbounds -Mchkptr -Ktrap=divz,fp,inv,ovf -traceback" \
"LDFLAGS_DEBUG = -O0 -g -Mbounds -Mchkptr -Ktrap=divz,fp,inv,ovf -traceback -lnvhpcwrapnvtx" \
"FFLAGS_OMP = -mp" \
"CFLAGS_OMP = -mp" \
"FFLAGS_ACC = -Mnofma -acc -ta=tesla:cc70,cc80 -Minfo=accel" \
"FFLAGS_ACC = -acc=gpu -Minfo=acc -gpu=lineinfo,ccnative,safecache -cuda" \
"CFLAGS_ACC =" \
"PICFLAG = -fpic" \
"BUILD_TARGET = $(@)" \
Expand Down
Loading