Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable GPU execution of atm_bdy_adjust_dynamics_speczone_tend via OpenACC #1268

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

gdicker1
Copy link
Collaborator

This PR adds OpenACC directives so the atm_bdy_adjust_dynamics_speczone_tend routine can execute on GPU(s).

Timing information for the OpenACC data transfers in this routine is captured in the log file by a new timer: atm_bdy_adjust_dynamics_speczone_tend [ACC_data_xfer].

@mgduda mgduda added Atmosphere OpenACC Work related to OpenACC acceleration of code labels Jan 17, 2025
@mgduda mgduda requested review from mgduda and abishekg7 January 17, 2025 22:32
@mgduda
Copy link
Contributor

mgduda commented Jan 31, 2025

@gdicker1 The changes themselves look good to me. I think a single commit would be sufficient for this PR.

Use OpenACC parallel and loop directives so this routine can be executed
on a GPU. More changes will be needed to improve performance.
@gdicker1 gdicker1 force-pushed the atmosphere/acc_atm_bdy_adjust_dynamics_speczone_tend branch from 83da840 to 991ba7b Compare January 31, 2025 19:23
@gdicker1
Copy link
Collaborator Author

@mgduda, pushed again with only 1 commit.

Copy link
Collaborator

@abishekg7 abishekg7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I check for bit reproducibility against an older version of develop - seems fine. You may want to do a check against the latest develop version after rebasing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Atmosphere OpenACC Work related to OpenACC acceleration of code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants