use equals!

MPDL · Jan 10, 2023 · 64af6f4 · 64af6f4
1 parent 7bf4026
commit 64af6f4
Showing 1 changed file with 3 additions and 6 deletions.
diff --git a/src/main/java/edu/harvard/iq/dataverse/datasetutility/AddReplaceFileHelper.java b/src/main/java/edu/harvard/iq/dataverse/datasetutility/AddReplaceFileHelper.java
@@ -420,9 +420,7 @@ private boolean runForceReplaceFile(Long oldFileId,
         if (!this.step_005_loadFileToReplaceById(oldFileId)){
             return false;
         }
-        logger.info("DS id: " + ds.getId());
-        logger.info("Owner id: " + fileToReplace.getOwner().getId());
-        if(ds.getId()!=fileToReplace.getOwner().getId()) {
+        if(!ds.getId().equals(fileToReplace.getOwner().getId())) {
             this.addErrorSevere(getBundleErr("existing_file_to_replace_not_in_dataset"));
             return false;
         }
@@ -464,9 +462,8 @@ private boolean runReplaceFile(Long oldFileId,
         if (!this.step_005_loadFileToReplaceById(oldFileId)){
             return false;
         }
-        logger.info("DS id: " + ds.getId());
-        logger.info("Owner id: " + fileToReplace.getOwner().getId());
-        if(ds.getId()!=fileToReplace.getOwner().getId()) {
+
+        if(!ds.getId().equals(fileToReplace.getOwner().getId())) {
             this.addErrorSevere(getBundleErr("existing_file_to_replace_not_in_dataset"));
             return false;
         }