Skip to content

Commit

Permalink
#40 Add Restarting the driver to more test classes
Browse files Browse the repository at this point in the history
-> Firefox/Jenkins crashed again because of the firefox memory leak.
This time caused by CreateMetadataFacetPrivate.
- Add Restarting the firefox drive to: CreateDefaultFacets,
CreateDefaultFacetsPrivate, CreateMetadataFacet,
CreateMetadataFacetPrivate
  • Loading branch information
helkv committed Apr 30, 2019
1 parent dfdacb6 commit 3618147
Show file tree
Hide file tree
Showing 5 changed files with 32 additions and 0 deletions.
7 changes: 7 additions & 0 deletions src/test/scripts/facets/CreateDefaultFacets.java
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

import org.testng.Assert;
import org.testng.annotations.AfterClass;
import org.testng.annotations.BeforeClass;
import org.testng.annotations.Test;

import spot.pages.CollectionEntryPage;
Expand Down Expand Up @@ -30,6 +31,12 @@ public class CreateDefaultFacets extends BaseSelenium {
private String organizationsFacet = "Organizations facet: " + TimeStamp.getTimeStamp();
private String licenseFacet = "License facet: " + TimeStamp.getTimeStamp();

@BeforeClass
public void resetDriver() {
// Restart the browser to prevent Firefox from crashing (see Ticket #40 'Firefox memory leak')
restartDriver();
}

@Test(priority = 1)
public void switchPrivateMode() {
LoginPage loginPage = new StartPage(driver).openLoginForm();
Expand Down
7 changes: 7 additions & 0 deletions src/test/scripts/facets/CreateDefaultFacetsPrivate.java
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

import org.testng.Assert;
import org.testng.annotations.AfterClass;
import org.testng.annotations.BeforeClass;
import org.testng.annotations.Test;

import spot.pages.CollectionEntryPage;
Expand Down Expand Up @@ -30,6 +31,12 @@ public class CreateDefaultFacetsPrivate extends BaseSelenium {
private String organizationsFacet = "Organizations facet: " + TimeStamp.getTimeStamp();
private String licenseFacet = "License facet: " + TimeStamp.getTimeStamp();

@BeforeClass
public void resetDriver() {
// Restart the browser to prevent Firefox from crashing (see Ticket #40 'Firefox memory leak')
restartDriver();
}

@Test(priority = 1)
public void switchPrivateMode() {
LoginPage loginPage = new StartPage(driver).openLoginForm();
Expand Down
7 changes: 7 additions & 0 deletions src/test/scripts/facets/CreateMetadataFacet.java
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

import org.testng.Assert;
import org.testng.annotations.AfterClass;
import org.testng.annotations.BeforeClass;
import org.testng.annotations.Test;

import spot.components.MessageComponent.MessageType;
Expand Down Expand Up @@ -63,6 +64,12 @@ public class CreateMetadataFacet extends BaseSelenium {

//NOTE: Facets of type Geolocation are not allowed to be created (see Imeji Ticket: #900) => Therefore there is no test step "facetGeolocation"

@BeforeClass
public void resetDriver() {
// Restart the browser to prevent Firefox from crashing (see Ticket #40 'Firefox memory leak')
restartDriver();
}

/**
* IMJ-21
*/
Expand Down
7 changes: 7 additions & 0 deletions src/test/scripts/facets/CreateMetadataFacetPrivate.java
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

import org.testng.Assert;
import org.testng.annotations.AfterClass;
import org.testng.annotations.BeforeClass;
import org.testng.annotations.Test;

import spot.components.MessageComponent.MessageType;
Expand Down Expand Up @@ -62,6 +63,12 @@ public class CreateMetadataFacetPrivate extends BaseSelenium {
private String statementNewNumber = "New Number statement: " + TimeStamp.getTimeStamp();
private String statementNewNumberValue = "2000.0";

@BeforeClass
public void resetDriver() {
// Restart the browser to prevent Firefox from crashing (see Ticket #40 'Firefox memory leak')
restartDriver();
}

@Test(priority = 1)
public void switchPrivateMode() {
LoginPage loginPage = new StartPage(driver).openLoginForm();
Expand Down
4 changes: 4 additions & 0 deletions src/test/scripts/highVolume/CreateMultipleStatements.java
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

import org.testng.Assert;
import org.testng.annotations.AfterClass;
import org.testng.annotations.BeforeClass;
import org.testng.annotations.Test;

import spot.pages.LoginPage;
Expand All @@ -23,6 +24,9 @@ public class CreateMultipleStatements extends BaseSelenium{

private final int numberOfStatements = 550;

//FIXME: Running this test can lead in a crash of Firefox (see Ticket #40 'Firefox memory leak').
//Workaround: Use Chrome in stead of Firefox to run this tests class.

/**
* IMJ-21
*/
Expand Down

0 comments on commit 3618147

Please sign in to comment.