Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Oracle Driver #1

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

diegodfsd
Copy link

Added Oracle Driver

@MattDavies
Copy link
Member

Hi Diego,

Thanks for the pull request! Really awesome to see this library being actively used, and Oracle driver support would definitely be of huge benefit to some people.

Before I merge this in, I just wanted to confirm you definitely need this driver to use System.Data.OracleClient. That's been deprecated for a while in favour of Oracle.DataAccess and the newer (and much nicer) Oracle.ManagedDataAccess.

I think it would make sense to rename MiniProfilerOracle10ClientDriver -> MiniProfilerOracleClientDriver and add an xmldoc comment explaining that you need System.Data.OracleClient 2.0.0.0 referenced to use it. We can additionally add in support for OracleDataClientDriver and OracleManagedDataClientDriver at a later date.

One other issue as well that I've added a line comment for.

If you're happy with all the above I'll make those tweaks and push out a package tonight.

Thanks again!

Cheers
Matt

@robdmoore
Copy link
Member

The SQL 2008 client driver seems to have all its line endings changed; you probably should make sure the commits use consistent line endings (crlf for everything - you might need to turn off the autocrlf setting on your git to achieve that). We should probably put in a gitattributes file to prevent that happening in the future as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants