-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Update Dockerfile #3039
[ENH] Update Dockerfile #3039
Conversation
Is there a way to add just the requisite runtime system dependencies to the image recipe rather than resorting to the non-slim base? If it’s just a couple of things missing here and there, it’d be preferable to add those explicitly, just to keep the size as small as possible. If it’s a very long list, or the reduction in size that would be achieved is minimal, then just adopting the non-slim base is justified. |
Thanks for the quick review, I'm going to check. I also sent you an email and put @jdtournier in cc for more context. |
Ah OK; this is actually a superset of #2929. Clearly there I made the decision that along with fixing how the dependencies are captured I also wanted to increment the dependency version. I'd prefer to merge #2929 first, after which this PR should show only the proposed change that is specific to your need. |
@Lestropie @MRtrix3/mrtrix3-devs IMO Ready to be merged 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Dockerfile has not been update for quite some time, I based my modifications on your branch container_eddyqc_fix and based the whole container on the non slim version of python3.8 to get more core system commands.