Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Update Dockerfile #3039

Merged
merged 4 commits into from
Nov 26, 2024
Merged

[ENH] Update Dockerfile #3039

merged 4 commits into from
Nov 26, 2024

Conversation

arnaudbore
Copy link
Contributor

Dockerfile has not been update for quite some time, I based my modifications on your branch container_eddyqc_fix and based the whole container on the non slim version of python3.8 to get more core system commands.

@Lestropie Lestropie self-assigned this Nov 20, 2024
@Lestropie Lestropie added the container Docker or Singularity containers label Nov 20, 2024
@Lestropie
Copy link
Member

Is there a way to add just the requisite runtime system dependencies to the image recipe rather than resorting to the non-slim base? If it’s just a couple of things missing here and there, it’d be preferable to add those explicitly, just to keep the size as small as possible. If it’s a very long list, or the reduction in size that would be achieved is minimal, then just adopting the non-slim base is justified.

@Lestropie Lestropie added this to the 3.0.5 updates milestone Nov 21, 2024
@arnaudbore
Copy link
Contributor Author

Thanks for the quick review, I'm going to check. I also sent you an email and put @jdtournier in cc for more context.

Dockerfile Outdated Show resolved Hide resolved
@Lestropie
Copy link
Member

Ah OK; this is actually a superset of #2929. Clearly there I made the decision that along with fixing how the dependencies are captured I also wanted to increment the dependency version. I'd prefer to merge #2929 first, after which this PR should show only the proposed change that is specific to your need.

@arnaudbore
Copy link
Contributor Author

arnaudbore commented Nov 26, 2024

@Lestropie @MRtrix3/mrtrix3-devs IMO Ready to be merged 👍
Once done can you push a "latest" container on dockerhub ?

Copy link
Member

@jdtournier jdtournier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jdtournier jdtournier added this pull request to the merge queue Nov 26, 2024
Merged via the queue into MRtrix3:master with commit 35dc21e Nov 26, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
container Docker or Singularity containers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants