labelconvert LUTs for Schaefer parcellations #3043
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #2669.
Includes a portion of #2330.
So there's a few things to unpack here:
edited documentation 5ttgen hsvs -white_stem #2330 includes some additional LUTs, however they are interspersed with many other proposed changes. I have manually extracted specifically the new LUTs from that PR.
One issue with the contribution of such text files to the code base is that the number of line modifications can be disproportionate with respect to the volume of effort involved. This can unjustly undermine the volume of effort invested by others into modification of source code. One way that we have tried to mitigate this (admittedly with numerous failures to do so in the history prior to coming up with the idea) is by taking those changes that are primarily the result of automatic content generation / for which the line change count is disproportionately high with respect to effort invested, and attributing the corresponding commit to "MRtrixBot [email protected]".
I have used this in the context of this PR in two ways, which I hope is considered fair to all parties involved.
There are two different versions of LUTs for the 200-node parcellation. The one from @nicdc in edited documentation 5ttgen hsvs -white_stem #2330 only contains the cortical parcels. Whereas all tables from Schaefer2018 7/17 Networks LUT files #2669 by @ppruc include the FreeSurfer sub-cortical GM parcel labels. Longer-term, I would prefer to have the ability to treat cortical parcellations and sub-cortical parcellations independently and aggregate them as one chooses; just as we do in this published work, and described in ENH labelconvert: Multiple inputs #2481. FOr here I'm content to simply add all files as-is; the software is in no way hard-coded to use these files, they are merely provided in case of utility.
While not "bug fixes", given that these changes are purely addition of text files that are not referenced in source code in any way, I'm content to push to
master
rather than deferring todev
.