patch temporary fix to address WF2 error unexpected relative url
#86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Patch to `run_msf_addons.sh` to address issue Josh was facing when testing WF2 `Get Encounters` step. This step uses `http` adaptor because we query the OMRS FHIR api, which requires `baseUrl` in the auth configuration... but the `omrs` adaptor (used in the other workflow steps) uses `instanceUrl`. In the immediate term, Josh addressed this by manually adding a new credential with `baseUrl` to the WF2 in his deployed instance. Merge this change if you want to ensure deployment of this `project.yaml` will work instantly, without manual intervention. Otherwise next week (estimated date: Jan 22), there will be an `openmrs` adaptor release with an enhancement that we can leverage and apply to the `project.yaml` file so that _all_ OMRS workflow steps can use the `openmrs` adaptor. If no rush, then you can wait until this upcoming change, and not merge this PR.
jnsereko
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch to
run_msf_addons.shto address issue Joshua was facing when testing WF2Get Encountersstep. This step useshttpadaptor because we query the OMRS FHIR api, which requiresbaseUrlin the auth configuration... but theomrsadaptor (used in the other workflow steps) usesinstanceUrl. In the immediate term, Josh addressed this by manually adding a new credential withbaseUrlto the WF2 in his deployed instance.Merge this change if you want to ensure deployment of this
project.yamlwill work instantly, without manual intervention.Otherwise next week (estimated date: Jan 22), there will be an
openmrsadaptor release with an enhancement that we can leverage and apply to theproject.yamlfile so that all OMRS workflow steps can use theopenmrsadaptor. If no rush, then you can wait until this upcoming change next week, and not yet merge this PR. Be in touch!Related Issue
See slack msg where Joshua flagged
Get Encountersstep in WF2 fails with errorUNEXPECTED_RELATIVE_URL