Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QA] Suppression du code mort lié à l'ancien formulaire #2315

Merged
merged 10 commits into from
Mar 15, 2024

Conversation

emilschn
Copy link
Collaborator

@emilschn emilschn commented Mar 4, 2024

Ticket

#2294

Description

Avec le feature flipping pour activer le nouveau formulaire, il restait quelques parties liées à l'ancien formulaire.
Donc suppression du feature flipping

Tests

  • Faire un tour sur le site, sur la page de création de signalement, liste des signalements, affichage de nouveaux et anciens signalements, affichage page de suivi usager, ... autre ?

@emilschn emilschn marked this pull request as draft March 4, 2024 17:24
@emilschn emilschn changed the title [QA] Suppression du code mort lié à l'ancien formulaire [WIP] [QA] Suppression du code mort lié à l'ancien formulaire Mar 4, 2024
@emilschn emilschn marked this pull request as ready for review March 5, 2024 10:07
@emilschn emilschn changed the title [WIP] [QA] Suppression du code mort lié à l'ancien formulaire [QA] Suppression du code mort lié à l'ancien formulaire Mar 5, 2024
Copy link
Collaborator

@numew numew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deux remarque et un test KO

src/Controller/Back/SignalementController.php Outdated Show resolved Hide resolved
src/Form/SignalementType.php Show resolved Hide resolved
public/js/app.js Outdated Show resolved Hide resolved
Copy link
Collaborator

@sfinx13 sfinx13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Il me semble que SituationType n'est plus ou pas utilisé

@emilschn emilschn force-pushed the feature/2294-remove-form-flipping branch from fb3bd36 to a8d3743 Compare March 11, 2024 16:09
@emilschn emilschn force-pushed the feature/2294-remove-form-flipping branch from 2198d6b to 8ae7735 Compare March 12, 2024 13:13
@emilschn
Copy link
Collaborator Author

@sfinx13 @hmeneuvrier @numew les retours sont traités :)
Merci !

Copy link

sonarcloud bot commented Mar 12, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Collaborator

@numew numew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lecture et tests OK

Copy link
Collaborator

@hmeneuvrier hmeneuvrier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-relecture OK, re-tests OK (j'ai retesté toutes les routes du FrontSignalementController pour être sûre, et j'ai repéré un autre bug sur la reprise de brouillon

@hmeneuvrier hmeneuvrier merged commit e3ac3a1 into develop Mar 15, 2024
3 checks passed
@hmeneuvrier hmeneuvrier deleted the feature/2294-remove-form-flipping branch March 15, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants