[Zone de vigilance] Ajout de la période sur l'infobulle des zones de vigilance #1912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maximeperraultdev
force-pushed
the
maxime/feat/1875/add_periode_to_vigilance_area_overlay
branch
from
d6a17ba to
87d9987
Compare
claire2212
approved these changes
Dec 5, 2024
| @@ -5,7 +5,7 @@ import type { VigilanceArea } from '@features/VigilanceArea/types' | |||
| import type { AMPProperties } from 'domain/entities/AMPs' | |||
| import type { RegulatoryLayerCompactProperties } from 'domain/entities/regulatory' | |||
|
|
|||
| export const getTitle = name => (name ? `${name?.replace(/[_]/g, ' ')}` : '') | |||
| export const getTitle = (name?: string | undefined | null) => (name ? `${name?.replace(/[_]/g, ' ')}` : '') | |||
There was a problem hiding this comment.
pourquoi null, on est censés, avoir que des undefined. Si y'a des null qui trainent on peut les enlever je pense.
maximeperraultdev
force-pushed
the
maxime/feat/1875/add_periode_to_vigilance_area_overlay
branch
from
ad3e44a to
9d18f47
Compare
|
claire2212
deleted the
maxime/feat/1875/add_periode_to_vigilance_area_overlay
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Pull Requests & Issues