Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TRA 14646] - Ajout de courtier/négociant sur BSVHU #3645

Merged
merged 14 commits into from
Oct 16, 2024
Merged

[TRA 14646] - Ajout de courtier/négociant sur BSVHU #3645

merged 14 commits into from
Oct 16, 2024

Conversation

silto
Copy link
Collaborator

@silto silto commented Oct 8, 2024 •
edited
Loading

Objectif

  • ajouter un courtier au BSVHU
  • ajouter un négociant au BSVHU

Bonus

  • Recipify basé sur le même modèle que Sirenify, rendu utile par l'ajout de recipify broker et trader. Donc au lieu d'avoir 3 fonctions différentes, à réimplémenter dans tous les bsd qui ont besoin de recipify, je me suis permis un refacto.
    J'ai remplacé les recipify sur BSDA, BSFF et BSPAOH avec ce nouveau recipify pour l'homogénéité (càd les bordereaux avec validation Zod)
  • dans la validation d'entreprise destinataire VHU, ajout de la validation du sous profil (broyeur/démolisseur) qui n'était pas faite alors que ça devrait être le cas
  • Mettre à jour la documentation
  • Mettre à jour le change log
  • Documenter les manipulations à faire lors de la mise en production (sur le ticket Favro de release)
  • S'assurer que la numérotation des nouvelles migrations est bien cohérente
  • Informer le data engineer de tout changement de schéma DB

@silto silto changed the title feat(BSVHU): add trader/broker (cherry picked) [TRA 14646] - Ajout de courtier/négociant sur BSVHU Oct 9, 2024
silto
silto commented Oct 9, 2024
View reviewed changes
benoitguigal
benoitguigal approved these changes Oct 10, 2024
View reviewed changes
Copy link
Member

@benoitguigal benoitguigal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice !

silto added 12 commits October 15, 2024 20:38
@silto
feat(BSVHU): add trader/broker (cherry picked)
76afb2d
@silto
test(BSVHU): add waste vehicules sub profiles to generic company fact…
37d502d 
…ory, remove useless logs
@silto
test(BSVHU): add waste vehicules sub profiles to bsvhu factory, remov…
6384868 
…e from generic company factory
@silto
test(BSVHU): fix tests
c6900b7
@silto
test(BSVHU): fix tests
e719a19
@silto
test(BSVHU): fix e2e tests
6a66e4b
@silto
fix(BSVHU): cleanup
ef7c03b
@silto
docs(Changelog): update Changelog
9b8f3e8
@silto
feat(BSVHU): check next destination type, add a way for destination r…
53c0a32 
…efinement to specify the right path for specific cases
@silto
test(BSVHU): add tests for next destination company check
30525d3
@silto
test(BSVHU): add recipify tests on BSVHU. Remove useless recipify on …
6564ab4 
…BSFF
@silto
feat(BSDA/BSFF/BSPAOH/BSVHU): rework zod transformers (sirenify/recip…
0254db0 
…ify) to be consistent throughout the code and better optimized. Cleanup a bit.
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
5 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
1.1% Duplication on New Code

See analysis details on SonarCloud

@silto silto merged commit 2bca533 into dev Oct 16, 2024
18 checks passed
@silto silto deleted the tra-14646-2 branch October 16, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@providenz providenz providenz approved these changes

@benoitguigal benoitguigal benoitguigal approved these changes

Assignees
No one assigned
Labels
ready for review ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@silto @providenz @benoitguigal