Merge pull request #1050 from MTES-MCT/eslint

chore: upgrade to ESLint v8 and fix linting issues

eslint.config.mjs

@@ -0,0 +1,86 @@
+import typescriptEslint from "@typescript-eslint/eslint-plugin";
+import _import from "eslint-plugin-import";
+import { fixupPluginRules, fixupConfigRules } from "@eslint/compat";
+import globals from "globals";
+import tsParser from "@typescript-eslint/parser";
+import path from "node:path";
+import { fileURLToPath } from "node:url";
+import js from "@eslint/js";
+import { FlatCompat } from "@eslint/eslintrc";
+
+const __filename = fileURLToPath(import.meta.url);
+const __dirname = path.dirname(__filename);
+const compat = new FlatCompat({
+    baseDirectory: __dirname,
+    recommendedConfig: js.configs.recommended,
+    allConfig: js.configs.all
+});
+
+export default [{
+    ignores: [
+        "**/build/",
+        "**/dist/",
+        "frontend/src/components/_dsfr/",
+        "frontend/jest.polyfills.js",
+        "**/node_modules/",
+        "**/public/",
+        "**/tools/",
+        "**/README.md",
+        "**/bin",
+        "**/Procfile",
+        "**/jest.config.js",
+        "**/.eslintrc.json",
+        "**/package.json",
+        "**/package-lock.json",
+        "**/yarn.lock",
+        "**/cron.json",
+        "**/*.css",
+        "**/*.hbs",
+        "server/jest.config.ts",
+        "frontend/jest.config.ts",
+    ],
+}, ...compat.extends("eslint:recommended", "plugin:@typescript-eslint/recommended", "prettier"), {
+    plugins: {
+        "@typescript-eslint": typescriptEslint,
+        import: fixupPluginRules(_import),
+    },
+
+    languageOptions: {
+        globals: {
+            ...globals.node,
+        },
+
+        parser: tsParser,
+        ecmaVersion: 2023,
+        sourceType: "module",
+    },
+
+    rules: {
+        "@typescript-eslint/no-explicit-any": "off",
+        "@typescript-eslint/no-var-requires": "off",
+        "import/no-commonjs": "error",
+        eqeqeq: ["error", "always"],
+        semi: ["error", "always"],
+    },
+}, ...fixupConfigRules(compat.extends(
+    "plugin:react/recommended",
+    "plugin:react/jsx-runtime",
+    "plugin:react-hooks/recommended",
+)).map(config => ({
+    ...config,
+    files: ["frontend/src/**/*.ts?(x)"],
+})), {
+    files: ["frontend/src/**/*.ts?(x)"],
+
+    settings: {
+        react: {
+            version: "detect",
+        },
+    },
+
+    rules: {
+        "no-irregular-whitespace": ["error", {
+            skipJSXText: true,
+        }],
+    },
+}];

frontend/src/components/Auth/RequireAuth.tsx

@@ -4,6 +4,7 @@ import { Navigate, useLocation } from 'react-router-dom';
 import { useUser } from '../../hooks/useUser';
 import { useFetchInterceptor } from '../../hooks/useFetchInterceptor';
 
+// eslint-disable-next-line @typescript-eslint/no-empty-object-type
 interface RequireAuthProps {}
 
 function RequireAuth(props: PropsWithChildren<RequireAuthProps>) {

frontend/src/components/Auth/RequireGuest.tsx

@@ -3,6 +3,7 @@ import { PropsWithChildren } from 'react';
 import { useUser } from '../../hooks/useUser';
 import { Navigate } from 'react-router-dom';
 
+// eslint-disable-next-line @typescript-eslint/no-empty-object-type
 interface RequireGuestProps {}
 
 function RequireGuest(props: PropsWithChildren<RequireGuestProps>) {

frontend/src/components/Draft/PreviewButton.tsx

@@ -87,7 +87,7 @@ function PreviewButton(props: Readonly<Props>) {
           setIsSuccess(true);
         }
       }
-    } catch (error) {
+    } catch {
       setIsError(true);
     } finally {
       setIsLoading(false);

frontend/src/components/Image/Image.tsx

@@ -2,16 +2,7 @@ import { fr } from '@codegouvfr/react-dsfr';
 import styled from '@emotion/styled';
 import classNames from 'classnames';
 
-const responsiveValues = [
-  '1x1',
-  '2x3',
-  '3x2',
-  '3x4',
-  '4x3',
-  '16x9',
-  '32x9'
-] as const;
-type Responsive = (typeof responsiveValues)[number];
+type Responsive = '1x1' | '2x3' | '3x2' | '3x4' | '4x3' | '16x9' | '32x9';
 
 interface Props {
   alt: string;

frontend/src/components/_app/AppInfo/AppInfo.tsx

@@ -4,6 +4,7 @@ import { PropsWithChildren } from 'react';
 import styles from './app-info.module.scss';
 import { fr } from '@codegouvfr/react-dsfr';
 
+// eslint-disable-next-line @typescript-eslint/no-empty-object-type
 interface Props {}
 
 function AppInfo(props: PropsWithChildren<Props>) {

frontend/src/components/modals/HousingCreationModal/FillLocalId.tsx

@@ -55,7 +55,7 @@ const FillLocalId = forwardRef((props: StepProps, ref) => {
         ]);
         dispatch(changeCreator({ localId }));
         return 'review-housing';
-      } catch (error) {
+      } catch {
         return null;
       }
     }

frontend/src/components/modals/ModalStepper/ModalStepper.test.tsx

@@ -13,11 +13,11 @@ describe('Modal stepper', () => {
   const steps: Step[] = [
     {
       title: 'Title 1',
-      Component: forwardRef(() => <p>Step 1</p>),
+      Component: forwardRef(function Step1() { return <p>Step 1</p>; }),
     },
     {
       title: 'Title 2',
-      Component: forwardRef(() => <p>Step 2</p>),
+      Component: forwardRef(function Step2() { return <p>Step 2</p>; }),
     },
   ];
 

frontend/src/components/modals/ModalStepper/ModalStepper.tsx

@@ -68,7 +68,11 @@ function ModalStepper(props: Props) {
       onClick: async () => {
         const next = (await ref.current?.onNext?.()) ?? true;
         if (next) {
-          stepper.isOver() ? modal.close() : stepper.next();
+          if (stepper.isOver()) {
+            modal.close();
+          } else {
+            stepper.next();
+          }
         }
       },
     },

frontend/src/hooks/useClipboard.tsx

@@ -16,9 +16,11 @@ export function useClipboard(opts?: ClipboardOptions) {
   const [copied, setCopied] = useState(false);
 
   async function copy(data: ClipboardItems | string) {
-    typeof data === 'string'
-      ? await navigator.clipboard.writeText(data)
-      : await navigator.clipboard.write(data);
+    if (typeof data === 'string') {
+      await navigator.clipboard.writeText(data);
+    } else {
+      await navigator.clipboard.write(data);
+    }
 
     setCopied(true);
     delay(() => setCopied(false), options.timeout);

frontend/src/hooks/useUnsavedChanges.tsx

@@ -15,7 +15,11 @@ function useUnsavedChanges(props: Readonly<Props>) {
 
   useEffect(() => {
     if (blocker.state === 'blocked') {
-      window.confirm(message) ? blocker.proceed() : blocker.reset();
+      if (window.confirm(message)) {
+        blocker.proceed();
+      } else {
+        blocker.reset();
+      }
     }
   }, [blocker, message]);
 }

frontend/src/models/Draft.tsx

@@ -7,6 +7,7 @@ import {
 import { SenderPayload } from './Sender';
 import { DeepNonNullable } from 'ts-essentials';
 
+// eslint-disable-next-line @typescript-eslint/no-empty-object-type
 export interface Draft extends DraftDTO {}
 
 export interface DraftCreationPayload

frontend/src/models/GroupFilters.tsx

@@ -1 +1,2 @@
+// eslint-disable-next-line @typescript-eslint/no-empty-object-type
 export interface GroupFilters {}

frontend/src/models/HousingFilters.tsx

@@ -24,6 +24,7 @@ import { LocalityKindLabels, LocalityKinds } from './Locality';
 import EnergyConsumptionOption from '../components/_app/AppMultiSelect/EnergyConsumptionOption';
 import { VacancyYear } from './VacancyYear';
 
+// eslint-disable-next-line @typescript-eslint/no-empty-object-type
 export interface HousingFilters extends HousingFiltersDTO {}
 
 export const allOccupancyOptions: SelectOption<Occupancy>[] = [

frontend/src/views/Housing/test/HousingView.test.tsx

@@ -73,7 +73,6 @@ describe('Housing view', () => {
 
         const vacancyStartYear = await screen
           .findByText(/^Dans cette situation depuis/)
-          // eslint-disable-next-line testing-library/no-node-access
           .then((label) => label.nextElementSibling);
         expect(vacancyStartYear).toHaveTextContent('Inconnu');
       });
@@ -86,7 +85,6 @@ describe('Housing view', () => {
 
         const vacancyStartYear = await screen
           .findByText(/^Dans cette situation depuis/)
-          // eslint-disable-next-line testing-library/no-node-access
           .then((label) => label.nextElementSibling);
         expect(vacancyStartYear).toHaveTextContent('Moins d’un an');
       });
@@ -100,7 +98,6 @@ describe('Housing view', () => {
 
         const source = await screen
           .findByText(/^Source/)
-          // eslint-disable-next-line testing-library/no-node-access
           .then((label) => label.nextElementSibling);
         expect(source).toHaveTextContent('Fichiers fonciers (2023)');
       });

package.json

@@ -25,9 +25,12 @@
   "author": "",
   "license": "MIT",
   "devDependencies": {
+    "@eslint/compat": "^1.2.4",
+    "@eslint/eslintrc": "^3.2.0",
+    "@eslint/js": "^9.17.0",
     "@types/node": "^20.16.10",
-    "@typescript-eslint/eslint-plugin": "^7.18.0",
-    "@typescript-eslint/parser": "^7.18.0",
+    "@typescript-eslint/eslint-plugin": "^8.18.1",
+    "@typescript-eslint/parser": "^8.18.1",
     "eslint": "^8.57.1",
     "eslint-config-prettier": "^9.1.0",
     "eslint-plugin-import": "^2.30.0",
@@ -36,6 +39,7 @@
     "eslint-plugin-react": "^7.37.0",
     "eslint-plugin-react-hooks": "^4.6.2",
     "eslint-plugin-testing-library": "^6.3.0",
+    "globals": "^15.14.0",
     "husky": "^9.1.6",
     "is-ci": "^3.0.1",
     "jest": "^29.7.0",

packages/draft/src/pdf.ts

@@ -165,7 +165,7 @@ function createTransformer(opts: TransformerOptions) {
             const binaryString = atob(content);
             const len = binaryString.length;
             const bytes = new Uint8Array(len);
-          
+
             for (let i = 0; i < len; i++) {
               bytes[i] = binaryString.charCodeAt(i);
             }

server/src/controllers/fileRepository.ts

@@ -27,7 +27,7 @@ export async function download(logo: string): Promise<FileUploadDTO> {
       url: logo,
       type: response.ContentType ?? 'base64'
     };
-  } catch (error) {
+  } catch {
     throw new FileMissingError();
   }
 }