Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add new jobs and assets for retrieving BAN addresses for owner and housings #1070

Merged
merged 12 commits into from
Jan 28, 2025
Merged

feat: add new jobs and assets for retrieving BAN addresses for owner and housings #1070

merged 12 commits into from
Jan 28, 2025

Conversation

loicguillois
Copy link
Collaborator

@loicguillois loicguillois commented Jan 2, 2025 •
edited
Loading

image

@gitguardian GitGuardian
Copy link

gitguardian bot commented Jan 2, 2025 •
edited
Loading

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
While these secrets were previously flagged, we no longer have a reference to the
specific commits where they were detected. Once a secret has been leaked into a git
repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@notion-workspace Notion Workspace
Copy link

🏦 [Adresses proprio] Compléter les adresses BAN propriétaires qui n’en ont pas (autres que LOVAC 24)

@loicguillois loicguillois marked this pull request as draft January 2, 2025 15:44
@loicguillois loicguillois marked this pull request as ready for review January 14, 2025 09:28
@notion-workspace Notion Workspace
Copy link

🏦 [Adresses proprio] Compléter les adresses BAN Logements qui n’en ont pas

rcourivaud
rcourivaud reviewed Jan 20, 2025
View reviewed changes
analytics/dagster/src/assets/populate_housings_ban_addresses.py Outdated Show resolved Hide resolved
analytics/dagster/src/assets/populate_housings_ban_addresses.py Outdated Show resolved Hide resolved
analytics/dagster/src/assets/populate_housings_ban_addresses.py Outdated Show resolved Hide resolved
analytics/dagster/src/assets/populate_housings_ban_addresses.py Outdated Show resolved Hide resolved
analytics/dagster/src/assets/populate_housings_ban_addresses.py Outdated Show resolved Hide resolved
analytics/dagster/src/assets/populate_owners_ban_addresses.py Outdated Show resolved Hide resolved
analytics/dagster/src/assets/populate_owners_ban_addresses.py Outdated Show resolved Hide resolved
analytics/dagster/src/assets/populate_owners_ban_addresses.py Outdated Show resolved Hide resolved
rcourivaud
rcourivaud reviewed Jan 28, 2025
View reviewed changes
analytics/dagster/src/assets/populate_housings_ban_addresses.py

@asset(
description="Return housing records from `fast_housing` that have no matching entry in `ban_addresses`.",
required_resource_keys={"psycopg2_connection"}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

je pense qu'il y a une coquille ici ? Je pense que tu as renommé la ressource entre temps ?

Copy link
Collaborator Author

@loicguillois loicguillois Jan 28, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

il y a bien deux ressources : psycopg2_connection et sqlalchemy_engine

analytics/dagster/src/assets/populate_housings_ban_addresses.py
"""

try:
with context.resources.psycopg2_connection as conn:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utilisation ici

@loicguillois loicguillois merged commit bc54d16 into main Jan 28, 2025
4 of 5 checks passed
@loicguillois loicguillois deleted the dagster-ban-address branch January 28, 2025 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rcourivaud rcourivaud rcourivaud approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@loicguillois @rcourivaud