Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use DYNAMIC_LIST to limit the number of kernels compiled into the wheel #166

Closed
wants to merge 8 commits into from
Closed

use DYNAMIC_LIST to limit the number of kernels compiled into the wheel #166

wants to merge 8 commits into from

Conversation

mattip
Copy link
Collaborator

@mattip mattip commented Jul 25, 2024 •
edited
Loading

Closes #144. Based on the analysis done in that issue.

  • I updated the version in pyproject.toml and made sure it matches git describe --tags --abbrev=8 in OpenBLAS at the OPENBLAS_COMMIT

@mattip mattip mentioned this pull request Jul 29, 2024
Open
@mattip
Copy link
Collaborator Author

mattip commented Jul 29, 2024

Rebased off main and tried limiting the aarch64 builds to see if that clears the Travis error.

mattip
mattip commented Jul 29, 2024
View reviewed changes
tools/build_steps.sh Outdated Show resolved Hide resolved
@mattip
Copy link
Collaborator Author

mattip commented Jul 30, 2024

Rebased off #169 which fixed the travis error by updating to latest HEAD.

@mattip
Copy link
Collaborator Author

mattip commented Jul 30, 2024

musllinux_1_1_aarch64 build is failing since it only has gcc version 9.3, which does not have arm64_sve.h so the NEOVERSEV1 build fails. Another reason to move to musllinux_1_2_aarch64 which has gcc 13.2.1, see numpy/numpy#27066

@carlkl carlkl mentioned this pull request Aug 8, 2024
Open
@mattip mattip mentioned this pull request Aug 8, 2024
Closed
@mattip
Copy link
Collaborator Author

mattip commented Aug 8, 2024

Let's limit this to x86_64 for now, we can revisit the aarch64 size after the NumPy 2.1 release.

@mattip mattip mentioned this pull request Aug 11, 2024
Merged
1 task
@mattip
Copy link
Collaborator Author

mattip commented Aug 11, 2024

Replaced by #179. Closing. We can try to shrink aarch64 in a diffferent PR/issue.

@mattip mattip closed this Aug 11, 2024
@mattip mattip mentioned this pull request Aug 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Shrink x86_64 blas library size
1 participant
@mattip